From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 765FD1F859 for ; Tue, 16 Aug 2016 16:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbcHPQOd convert rfc822-to-8bit (ORCPT ); Tue, 16 Aug 2016 12:14:33 -0400 Received: from zm-etu-ensimag-2.grenet.fr ([130.190.244.118]:54245 "EHLO zm-etu-ensimag-2.grenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbcHPQO3 (ORCPT ); Tue, 16 Aug 2016 12:14:29 -0400 Received: from localhost (localhost [127.0.0.1]) by zm-smtpout-2.grenet.fr (Postfix) with ESMTP id A6356202B; Tue, 16 Aug 2016 18:14:25 +0200 (CEST) Received: from zm-smtpout-2.grenet.fr ([127.0.0.1]) by localhost (zm-smtpout-2.grenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KiLwQu4WN697; Tue, 16 Aug 2016 18:14:25 +0200 (CEST) Received: from zm-int-mbx1.grenet.fr (zm-int-mbx1.grenet.fr [130.190.242.140]) by zm-smtpout-2.grenet.fr (Postfix) with ESMTP id 92D68200E; Tue, 16 Aug 2016 18:14:25 +0200 (CEST) Date: Tue, 16 Aug 2016 18:35:29 +0200 (CEST) From: Remi Galan Alfonso To: Johannes Schindelin Cc: git@vger.kernel.org, Junio C Hamano , ryenus , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Jeff King Message-ID: <1654103856.1228422.1471365329111.JavaMail.zimbra@ensimag.grenoble-inp.fr> In-Reply-To: References: <520a941f7472ac1cb4fa41e6bba33a0afc2f5999.1471264971.git.johannes.schindelin@gmx.de> <1134106438.1228353.1471361364992.JavaMail.zimbra@ensimag.grenoble-inp.fr> Subject: Re: [PATCH v2] rev-parse: respect core.hooksPath in --git-path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [130.190.242.137] X-Mailer: Zimbra 8.0.9_GA_6191 (ZimbraWebClient - FF39 (Linux)/8.0.9_GA_6191) Thread-Topic: rev-parse: respect core.hooksPath in --git-path Thread-Index: P7ZVOPlTnwRTXtPALSIGSv+efwoKmg== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: > Hi Rémi, > > On Tue, 16 Aug 2016, Remi Galan Alfonso wrote: > > > Johannes Schindelin writes: > > > diff --git a/t/t1350-config-hooks-path.sh b/t/t1350-config-hooks-path.sh > > > index 5e3fb3a..f1f9aee 100755 > > > --- a/t/t1350-config-hooks-path.sh > > > +++ b/t/t1350-config-hooks-path.sh > > > @@ -34,4 +34,10 @@ test_expect_success 'Check that various forms of specifying core.hooksPath work' > > > test_cmp expect actual > > > ' > > > > > > +test_expect_success 'git rev-parse --git-path hooks' ' > > > + git config core.hooksPath .git/custom-hooks && > > > > Any reason to not use 'test_config' here? > > Yes: consistency. The rest of the script uses `git config`, not > `test_config`. Fine by me, then. Sorry for the noise. > Ciao, > Dscho Ciao, Rémi