From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
ryenus <ryenus@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2] rev-parse: respect core.hooksPath in --git-path
Date: Tue, 16 Aug 2016 18:35:29 +0200 (CEST) [thread overview]
Message-ID: <1654103856.1228422.1471365329111.JavaMail.zimbra@ensimag.grenoble-inp.fr> (raw)
In-Reply-To: <alpine.DEB.2.20.1608161739280.4924@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Rémi,
>
> On Tue, 16 Aug 2016, Remi Galan Alfonso wrote:
>
> > Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> > > diff --git a/t/t1350-config-hooks-path.sh b/t/t1350-config-hooks-path.sh
> > > index 5e3fb3a..f1f9aee 100755
> > > --- a/t/t1350-config-hooks-path.sh
> > > +++ b/t/t1350-config-hooks-path.sh
> > > @@ -34,4 +34,10 @@ test_expect_success 'Check that various forms of specifying core.hooksPath work'
> > > test_cmp expect actual
> > > '
> > >
> > > +test_expect_success 'git rev-parse --git-path hooks' '
> > > + git config core.hooksPath .git/custom-hooks &&
> >
> > Any reason to not use 'test_config' here?
>
> Yes: consistency. The rest of the script uses `git config`, not
> `test_config`.
Fine by me, then. Sorry for the noise.
> Ciao,
> Dscho
Ciao,
Rémi
next prev parent reply other threads:[~2016-08-16 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 12:43 [PATCH] rev-parse: respect core.hooksPath in --git-path Johannes Schindelin
2016-08-15 12:50 ` Jeff King
2016-08-16 12:42 ` Johannes Schindelin
2016-08-16 13:06 ` Jeff King
2016-08-16 13:14 ` [PATCH v2] " Johannes Schindelin
2016-08-16 15:29 ` Remi Galan Alfonso
2016-08-16 15:55 ` Johannes Schindelin
2016-08-16 16:35 ` Remi Galan Alfonso [this message]
2016-08-16 20:28 ` Junio C Hamano
2016-08-17 8:43 ` Remi Galan Alfonso
2016-08-17 15:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1654103856.1228422.1471365329111.JavaMail.zimbra@ensimag.grenoble-inp.fr \
--to=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ryenus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).