From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2022, #02; Tue, 7)
Date: Wed, 8 Jun 2022 12:56:17 -0400 [thread overview]
Message-ID: <15dd34af-14c1-5b41-5d33-a2e3b9611c25@gmail.com> (raw)
In-Reply-To: <xmqqwndsrm99.fsf@gitster.g>
Hi Junio,
Le 2022-06-07 à 21:12, Junio C Hamano a écrit :
> * pb/range-diff-with-submodule (2022-06-06) 1 commit
> (merged to 'next' on 2022-06-07 at e5e31590c4)
> + range-diff: show submodule changes irrespective of diff.submodule
>
> "git range-diff" did not show anything for submodules that changed
> in the ranges being compared. Change the behaviour to include the
> "--submodule=short" output unconditionally to be compared.
>
> Will merge to 'master'.
> source: <pull.1244.v2.git.1654549153769.gitgitgadget@gmail.com>
>
I think the merge message (and thus the mention in the release notes)
could be more precise, maybe something like this:
"git -c diff.submodule=log range-diff" did not show anything for
submodules that changed in the ranges being compared, and
"git -c diff.submodule=diff range-diff" did not work correctly.
Change the behaviour to include the "--submodule=short" output
unconditionally to be compared.
next prev parent reply other threads:[~2022-06-08 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 1:12 What's cooking in git.git (Jun 2022, #02; Tue, 7) Junio C Hamano
2022-06-08 16:56 ` Philippe Blain [this message]
2022-06-08 20:18 ` ds/rebase-update-refs (was Re: What's cooking in git.git (Jun 2022, #02; Tue, 7)) Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15dd34af-14c1-5b41-5d33-a2e3b9611c25@gmail.com \
--to=levraiphilippeblain@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).