From: Stephen Boyd <sboyd@kernel.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Xiaolong Ye <xiaolong.ye@intel.com>
Subject: Re: [PATCH 2/2] format-patch: Make --base patch-id output stable
Date: Tue, 07 May 2019 10:46:28 -0700 [thread overview]
Message-ID: <155725118838.14659.6891235578536334187@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqpnounakf.fsf@gitster-ct.c.googlers.com>
Quoting Junio C Hamano (2019-05-06 21:38:24)
> Stephen Boyd <sboyd@kernel.org> writes:
>
> > I wonder if we need to make some other sort of form of
> > "prerequisite-patch-id:" here and let that be a legacy form of the
> > patch-id so that users know that they have a fixed version of this code?
> > Maybe "prerequisite-stable-patch-id:"? Or we don't have to care because
> > it's been broken for anything besides the most trivial type of patches
> > and presumably users aren't able to use it with 'patch-id --stable'?
>
> Do projects actively use -O<orderfile> when generating the patches?
> I had an impression that not many do, and without -O<orderfile> in
> the picture, --unstable/--stable would not matter, no?
>
> So, I am not sure if this matters very much in practice.
>
I'm not really concerned with projects using -O<orderfile> for patch
generation. I'm concerned that the documentation told users to use
--stable and that didn't work for me when there was more than one hunk
in the patch. This leads me to believe that either I'm doing something
wrong or the other users of this feature have been using --unstable
since this was added to git format-patch.
next prev parent reply other threads:[~2019-05-07 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 23:51 [PATCH 1/2] format-patch: Inform user that patch-id generation is unstable Stephen Boyd
2019-04-26 23:51 ` [PATCH 2/2] format-patch: Make --base patch-id output stable Stephen Boyd
2019-05-07 4:38 ` Junio C Hamano
2019-05-07 17:46 ` Stephen Boyd [this message]
2019-05-08 2:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155725118838.14659.6891235578536334187@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).