git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Aaron Greenberg <p@aaronjgreenberg.com>
To: peff@peff.net
Cc: git@matthieu-moy.fr, git@vger.kernel.org, p@aaronjgreenberg.com,
	gitster@pobox.com
Subject: [PATCH v2] branch: implement shortcut to delete last branch
Date: Fri, 23 Mar 2018 22:40:34 +0000	[thread overview]
Message-ID: <1521844835-23956-1-git-send-email-p@aaronjgreenberg.com> (raw)
In-Reply-To: <20180323085636.GA24416@sigill.intra.peff.net>


I updated the commit message to include my first email's cover letter
and cleaned up the test.

Copying Junio, since he also had good comments in the conversation you
linked.

I can appreciate Matthieu's points on the use of "-" in destructive
commands. As of this writing, git-merge supports the "-" shorthand,
which while not destructive, is at least _mutative_. Also,
"git branch -d" is not destructive in the same way that "rm -rf" is
destructive since you can recover the branch using the reflog.

One thing to consider is that approval of this patch extends the
implementation of the "-" shorthand in a piecemeal, rather than
consistent, way (implementing it in a consistent way was the goal of
the patch set you mentioned in your previous email.) Is that okay? Or
is it better to pick up the consistent approach where it was left?

  parent reply	other threads:[~2018-03-23 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23  2:09 [PATCH] branch: implement shortcut to delete last branch Aaron Greenberg
2018-03-23  2:09 ` Aaron Greenberg
2018-03-23  8:56 ` Jeff King
2018-03-23  9:00   ` Jeff King
2018-03-23 22:40   ` Aaron Greenberg [this message]
2018-03-23 22:40     ` Aaron Greenberg
2018-03-26  8:10     ` [PATCH v2] " Jeff King
2018-03-26 12:41       ` git
2018-03-26 16:49         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521844835-23956-1-git-send-email-p@aaronjgreenberg.com \
    --to=p@aaronjgreenberg.com \
    --cc=git@matthieu-moy.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).