From: Harish Karumuthil <email@example.com> To: Pratyush Yadav <firstname.lastname@example.org>, Johannes Schindelin <Johannes.Schindelin@gmx.de> Cc: email@example.com, David Aguilar <firstname.lastname@example.org> Subject: Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts Date: Sun, 06 Oct 2019 01:46:41 +0530 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi All, From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I understood that, my current email client ( that is gmail web ) is not good for submitting patches. So I was tying to setup a mail client which is compatible with `git send-mail`. But I was not able to get a satisfactory result in that. For now, I followed the instruction of Johannes Schindelin and submitted a pull request . Please see https://github.com/gitgitgadget/git/pull/376 --------- @ Pratyush: Regarding your comments, > A pretty nice way of doing it. But I would _really_ like it if there was > an option in the "create tool" dialog to specify the shortcut. People of > a gui tool shouldn't have to mess around with config files as much as > possible. I agree with this, But that may require some more profficiency in TCL/TK programming which I don't have. This is the first time I am looking into a TCL/TK source code. Any way I will try to integrate the gui gradually in feature. But unfortunatly, I may not be able to do that now. > David has advocated inter-operability between git-gui and git-cola. > While I personally don't know how many people actually use both the > tools at the same time, it doesn't sound like a bad idea either. > > So, sharing shortcuts with git-cola would be nice. Of course, it would > then mean that we would have to parse the config parameter before > feeding them to `bind`. I don't suppose that should be something too > complicated to do, but I admit I haven't looked too deeply into it. IMHO, Using a uniform shortcut-key code/foramat for both application can be considered as nice feature. But, whether we should share common shortcut-scheme with both application is a different question. Currently, both apps don't have a common shortcut-scheme. So in this situation, only sharing custom-tool's shortcut-scheme with both applications doesn't look like a good idea to me > Are you sure that is a good idea? I think we should at least make sure > we are not binding some illegal sequence, and if we are, we should warn > the user about it. And a much more important case would be when a user > over-writes a pre-existing shortcut for other commands like "commit", > "reset", etc. In that case, the menu entires of those commands would > still be labelled with the shortcut, but it won't actually work. I agree with you. It is an important point. After reading this, I checked current status of these issues. What I found is given below. 1. When user provides an invalid sequence for the shortcut, it will cuase the entire gitgui application to crash at the startup 2. When user tries to overwrite existing shortcut, it will not have any effect. Because, built in shortcuts will overwrite user provided one. But still, wrong menu accelerator label will persist for custom tools Since #1 is a serious issue, I tried to find out the function which does the keycode validation, but I haven't succeded till now. ( I found the C function name which is "TkStringToKeysym" from TK source, but I couldn't find its TCL binding ). It will be helpful if any one can help me on this.
next prev parent reply other threads:[~2019-10-05 20:16 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-29 11:38 Harish K 2016-03-31 16:41 ` David Aguilar 2016-04-01 6:32 ` harish k 2019-10-03 14:48 ` harish k 2019-10-03 21:44 ` Pratyush Yadav 2019-10-04 8:49 ` Johannes Schindelin 2019-10-04 12:01 ` Pratyush Yadav 2019-10-05 20:16 ` Harish Karumuthil [this message] 2019-10-05 21:01 ` Pratyush Yadav 2019-10-06 9:49 ` Johannes Schindelin 2019-10-06 18:39 ` Pratyush Yadav 2019-10-06 19:37 ` Philip Oakley 2019-10-06 20:27 ` Johannes Schindelin 2019-10-06 21:06 ` Pratyush Yadav 2019-10-07 9:20 ` GitGUIGadget, was " Johannes Schindelin 2019-10-07 10:43 ` Birger Skogeng Pedersen 2019-10-07 19:16 ` Alban Gruin 2019-11-19 22:09 ` Making GitGitGadget's list -> PR comment mirroring bidirectional, " Johannes Schindelin 2019-11-20 14:22 ` Pratyush Yadav 2019-10-06 22:40 ` Philip Oakley 2019-10-07 6:22 ` Harish Karumuthil 2019-10-07 10:01 ` Johannes Schindelin 2019-10-08 19:31 ` Harish Karumuthil 2019-10-09 20:42 ` Johannes Schindelin 2019-10-13 20:09 ` Pratyush Yadav 2019-10-07 6:13 ` Harish Karumuthil 2019-10-13 19:17 ` Pratyush Yadav -- strict thread matches above, loose matches on Subject: below -- 2016-03-29 11:29 Harish K 2016-03-31 16:49 ` David Aguilar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --cc=Johannes.Schindelin@gmx.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
firstname.lastname@example.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ email@example.com public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git