From: Derrick Stolee <stolee@gmail.com>
To: Christian Couder <christian.couder@gmail.com>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Taylor Blau <me@ttaylorr.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] test-bloom: fix missing 'bloom' from usage string
Date: Tue, 6 Apr 2021 09:05:09 -0400 [thread overview]
Message-ID: <149395c6-1c68-cf8b-2322-e62b0e48c652@gmail.com> (raw)
In-Reply-To: <20210406023514.27060-1-chriscool@tuxfamily.org>
On 4/5/2021 10:35 PM, Christian Couder wrote:
> Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a
> subcommand of `test-tool bloom` not of `test-tool` itself.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> t/helper/test-bloom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> index 2a1ae3dae6..ad3ef1cd77 100644
> --- a/t/helper/test-bloom.c
> +++ b/t/helper/test-bloom.c
> @@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)
> static const char *bloom_usage = "\n"
> " test-tool bloom get_murmur3 <string>\n"
> " test-tool bloom generate_filter <string> [<string>...]\n"
> -" test-tool get_filter_for_commit <commit-hex>\n";
> +" test-tool bloom get_filter_for_commit <commit-hex>\n";
Obviously correct. Good find.
Thanks,
-Stolee
prev parent reply other threads:[~2021-04-06 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 2:35 [PATCH] test-bloom: fix missing 'bloom' from usage string Christian Couder
2021-04-06 13:05 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149395c6-1c68-cf8b-2322-e62b0e48c652@gmail.com \
--to=stolee@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).