From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] send-email: Net::SMTP::SSL is obsolete, use only when necessary
Date: Sun, 19 Mar 2017 00:14:23 +0100 [thread overview]
Message-ID: <1489878863.24742.3.camel@kaarsemaker.net> (raw)
In-Reply-To: <CACBZZX5j1dYk8aeRED7T7iJ=b32aFUpfUWPpMpmtofBL3QnVXQ@mail.gmail.com>
On Sat, 2017-03-18 at 23:47 +0100, Ævar Arnfjörð Bjarmason wrote:
> On Sat, Mar 18, 2017 at 11:23 PM, Dennis Kaarsemaker
> <dennis@kaarsemaker.net> wrote:
>
> > + require Net::SMTP;
> > + my $use_net_smtp_ssl = $Net::SMTP::VERSION lt "1.28";
> > + $smtp_domain ||= maildomain();
> > +
>
> While Net::SMTP is unlikely to change its versioning scheme, let's use
> comparisons via the version module here in case they do change it to
> something silly, and this ends up introducing a bug.
ok.
> > [...]
> > + if ($smtp->code != 220) {
> > + die sprintf(__("Server does not support STARTTLS! %s"), $smtp->message);
>
> Here a new message you're adding gets __(), makes sense.
Didn't add it, it just moved from a bit further below :)
> > + else {
> > + $smtp->starttls(ssl_verify_params())
> > + or die "STARTTLS failed! ".IO::Socket::SSL::errstr();
> > + }
>
> I see you just copied that from above but I wonder if it makes sense
> to just mark both occurrences with __() too while we're at it.
ok.
D.
next prev parent reply other threads:[~2017-03-18 23:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 21:18 [PATCH] Remove dependency on deprecated Net::SMTP::SSL Mike Fisher
2016-11-20 21:53 ` brian m. carlson
2017-01-13 14:59 ` Renato Botelho
2016-11-21 5:37 ` Torsten Bögershausen
2017-03-18 22:23 ` [PATCH] send-email: Net::SMTP::SSL is obsolete, use only when necessary Dennis Kaarsemaker
2017-03-18 22:47 ` Ævar Arnfjörð Bjarmason
2017-03-18 23:14 ` Dennis Kaarsemaker [this message]
2017-03-24 21:37 ` [PATCH v2] " Dennis Kaarsemaker
2017-05-04 7:01 ` Dennis Kaarsemaker
2017-05-19 20:54 ` Dennis Kaarsemaker
2017-05-20 7:56 ` Ævar Arnfjörð Bjarmason
2017-05-31 22:50 ` Junio C Hamano
2017-06-01 19:42 ` Dennis Kaarsemaker
2017-05-31 21:46 ` Jonathan Nieder
2017-05-31 22:39 ` Junio C Hamano
2017-05-31 22:53 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489878863.24742.3.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).