git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Valery Tolstov <me@vtolstov.org>
To: t.gummerer@gmail.com
Cc: git@vger.kernel.org, sbeller@google.com
Subject: Re: GSoC 2017
Date: Wed, 08 Mar 2017 02:22:00 +0300	[thread overview]
Message-ID: <1488928920.8812.2@smtp.yandex.ru> (raw)

Decided to rewrite module_clone to use connect_work_tree_and_git_dir
as my microproject by suggestion of Stefan Bellar.
https://public-inbox.org/git/CAGZ79kY+1E-wg0-uzGJmE+haOE+1WCmg0Eux7rWGtkU_aBDQ9g@mail.gmail.com/

It seems that connect_work_tree_and_git_dir needs to be slightly changed
to deal with submodules. Because path to config file for submodules lies
not directly in .git directory we need to know whether the path is
submodule or not. Can I use submodule_from_path to determine this?
I mean what if NULL result also indicates error sometimes?

Another possible solution is to pass the flag indicating
that path is submodule or not. But I think this solution is bad.


Regards,
  Valery Tolstov




             reply	other threads:[~2017-03-07 23:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 23:22 Valery Tolstov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-03-04 11:00 GSoC 2017 Valery Tolstov
2017-03-04 11:45 ` Thomas Gummerer
2017-03-04 17:26   ` Thomas Gummerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488928920.8812.2@smtp.yandex.ru \
    --to=me@vtolstov.org \
    --cc=20170304172648.GB27158@hank \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).