From: David Turner <novalis@novalis.org>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: "disabling bitmap writing, as some objects are not being packed"?
Date: Fri, 16 Dec 2016 16:40:16 -0500 [thread overview]
Message-ID: <1481924416.28176.19.camel@frank> (raw)
In-Reply-To: <20161216213214.z3mzkp2xqnwrqkh2@sigill.intra.peff.net>
On Fri, 2016-12-16 at 16:32 -0500, Jeff King wrote:
> On Fri, Dec 16, 2016 at 01:28:00PM -0800, Junio C Hamano wrote:
>
> > > 2. I don't understand what would cause that message. That is, what bad
> > > thing am I doing that I should stop doing? I've briefly skimmed the
> > > code and commit message, but the answer isn't leaping out at me.
> >
> > Enabling bitmap generation for incremental packing that does not
> > cram everything into a single pack is triggering it, I would
> > presume. Perhaps we should ignore -b option in most of the cases
> > and enable it only for "repack -a -d -f" codepath? Or detect that
> > we are being run from "gc --auto" and automatically disable -b? I
> > have a feeling that an approach along that line is closer to the
> > real solution than tweaking report_last_gc_error() and trying to
> > deduce if we are making any progress.
>
> Ah, indeed. I was thinking in my other response that "git gc" would
> always kick off an all-into-one repack. But "gc --auto" will not in
> certain cases. And yes, in those cases you definitely would want
> --no-write-bitmap-index. I think it would be reasonable for "git repack"
> to disable bitmap-writing automatically when not doing an all-into-one
> repack.
I do not have alternates and am not using --local. Nor do I have .keep
packs.
I would assume, based on the documentation, that auto gc would be doing
an all-into-one repack:
"If the number of packs exceeds the value of gc.autopacklimit, then
existing packs (except those marked with a .keep file) are
consolidated into a single pack by using the -A option of git
repack."
I don't have any settings that limit the size of packs, either. And a
manual git repack -a -d creates only a single pack. Its loneliness
doesn't last long, because pretty soon a new pack is created by an
incoming push.
Unless this just means that some objects are being kept loose (perhaps
because they are unreferenced)?
next prev parent reply other threads:[~2016-12-16 21:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 21:05 "disabling bitmap writing, as some objects are not being packed"? David Turner
2016-12-16 21:27 ` Jeff King
2016-12-16 21:28 ` Junio C Hamano
2016-12-16 21:32 ` Jeff King
2016-12-16 21:40 ` David Turner [this message]
2016-12-16 21:49 ` Jeff King
2016-12-16 23:59 ` [PATCH] pack-objects: don't warn about bitmaps on incremental pack David Turner
2016-12-17 4:04 ` Jeff King
2016-12-19 16:03 ` David Turner
2016-12-17 7:50 ` "disabling bitmap writing, as some objects are not being packed"? Duy Nguyen
2017-02-08 1:03 ` David Turner
2017-02-08 6:45 ` Duy Nguyen
2017-02-08 8:24 ` David Turner
2017-02-08 8:37 ` Duy Nguyen
2017-02-08 17:44 ` Junio C Hamano
2017-02-08 19:05 ` David Turner
2017-02-08 19:08 ` Jeff King
2017-02-08 22:14 ` David Turner
2017-02-08 23:00 ` Jeff King
2017-02-09 0:18 ` Junio C Hamano
2017-02-09 1:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481924416.28176.19.camel@frank \
--to=novalis@novalis.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).