From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com, peff@peff.net
Cc: git@vger.kernel.org, VADIME@il.ibm.com,
Stefan Beller <sbeller@google.com>
Subject: [PATCH] shallow clone to not imply shallow submodules
Date: Mon, 20 Jun 2016 09:59:58 -0700 [thread overview]
Message-ID: <1466441998-18896-1-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <xmqq7fdkx5oz.fsf@gitster.mtv.corp.google.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
Hi Junio, Peff,
I thought about this patch squashed into
"clone: do not let --depth imply --shallow-submodules" will actually test
for the regression.
Thanks,
Stefan
t/t5614-clone-submodules.sh | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/t/t5614-clone-submodules.sh b/t/t5614-clone-submodules.sh
index f7c630b..a9aaa01 100755
--- a/t/t5614-clone-submodules.sh
+++ b/t/t5614-clone-submodules.sh
@@ -37,7 +37,7 @@ test_expect_success 'nonshallow clone implies nonshallow submodule' '
)
'
-test_expect_success 'shallow clone does not imply shallow submodule' '
+test_expect_success 'shallow clone with shallow submodule' '
test_when_finished "rm -rf super_clone" &&
git clone --recurse-submodules --depth 2 --shallow-submodules "file://$pwd/." super_clone &&
(
@@ -52,6 +52,21 @@ test_expect_success 'shallow clone does not imply shallow submodule' '
)
'
+test_expect_success 'shallow clone does not imply shallow submodule' '
+ test_when_finished "rm -rf super_clone" &&
+ git clone --recurse-submodules --depth 2 "file://$pwd/." super_clone &&
+ (
+ cd super_clone &&
+ git log --oneline >lines &&
+ test_line_count = 2 lines
+ ) &&
+ (
+ cd super_clone/sub &&
+ git log --oneline >lines &&
+ test_line_count = 3 lines
+ )
+'
+
test_expect_success 'shallow clone with non shallow submodule' '
test_when_finished "rm -rf super_clone" &&
git clone --recurse-submodules --depth 2 --no-shallow-submodules "file://$pwd/." super_clone &&
--
2.7.0.rc0.40.g5328432.dirty
next prev parent reply other threads:[~2016-06-20 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OFC76C15DC.FC882C57-ONC2257FD7.00261552-C2257FD7.002660FC@LocalDomain>
2016-06-19 7:17 ` [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule Vadim Eisenberg
2016-06-19 10:00 ` Jeff King
2016-06-19 13:07 ` Vadim Eisenberg
2016-06-19 14:46 ` Jeff King
2016-06-19 20:51 ` Junio C Hamano
2016-06-20 0:13 ` Jeff King
2016-06-20 1:09 ` Stefan Beller
2016-06-20 3:01 ` Vadim Eisenberg
2016-06-20 5:31 ` Dennis Kaarsemaker
2016-06-20 10:02 ` Jeff King
2016-06-20 16:59 ` Stefan Beller [this message]
2016-06-20 17:13 ` [PATCH] shallow clone to not imply shallow submodules Jeff King
2016-06-20 17:14 ` Stefan Beller
2016-06-20 17:18 ` Jeff King
2017-04-19 11:30 ` [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule Ævar Arnfjörð Bjarmason
2017-04-19 18:54 ` Stefan Beller
2016-06-21 16:48 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466441998-18896-1-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=VADIME@il.ibm.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).