git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Eric Wong <e@80x24.org>
Subject: Re: [PATCH] use fspathhash() everywhere
Date: Fri, 30 Jul 2021 22:22:38 +0200	[thread overview]
Message-ID: <14653a9b-8999-78bc-03f7-b9f21954b873@web.de> (raw)
In-Reply-To: <xmqq35rv1u2a.fsf@gitster.g>

Am 30.07.21 um 21:27 schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> cf2dc1c238 (speed up alt_odb_usable() with many alternates, 2021-07-07)
>> introduced the function fspathhash() for calculating path hashes while
>> respecting the configuration option core.ignorecase.  Call it instead of
>> open-coding it; the resulting code is shorter and less repetitive.
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>> ---
>>  builtin/sparse-checkout.c | 10 ++--------
>>  dir.c                     | 13 +++----------
>>  merge-recursive.c         | 11 +++--------
>>  3 files changed, 8 insertions(+), 26 deletions(-)
>
> I love this kind of "now we have this thing available, let's use it
> at more places" clean-up patch.
>
> Was coccinelle involved in finding these places?

Just git grep this time; there were not enough hits for me to consider
writing a semantic patch.

René

      reply	other threads:[~2021-07-30 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 19:06 [PATCH] use fspathhash() everywhere René Scharfe
2021-07-30 19:27 ` Junio C Hamano
2021-07-30 20:22   ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14653a9b-8999-78bc-03f7-b9f21954b873@web.de \
    --to=l.s.r@web.de \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).