From: Pranit Bauva <pranit.bauva@gmail.com> To: git@vger.kernel.org Cc: Pranit Bauva <pranit.bauva@gmail.com>, larsxschneider@gmail.com, chriscool@tuxfamily.org, christian.couder@gmail.com, sunshine@sunshineco.com, Johannes.Schindelin@gmx.de Subject: [PATCH v7 1/3] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Date: Mon, 23 May 2016 20:18:46 +0530 [thread overview] Message-ID: <1464014928-31548-2-git-send-email-pranit.bauva@gmail.com> (raw) In-Reply-To: <1464014928-31548-1-git-send-email-pranit.bauva@gmail.com> `--next-all` is meant to be used as a subcommand to support multiple "operation mode" though the current implementation does not contain any other subcommand along side with `--next-all` but further commits will include some more subcommands. Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Mentored-by: Lars Schneider <larsxschneider@gmail.com> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> --- builtin/bisect--helper.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 3324229..8111c91 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -10,11 +10,11 @@ static const char * const git_bisect_helper_usage[] = { int cmd_bisect__helper(int argc, const char **argv, const char *prefix) { - int next_all = 0; + enum { NEXT_ALL = 1 } cmdmode = 0; int no_checkout = 0; struct option options[] = { - OPT_BOOL(0, "next-all", &next_all, - N_("perform 'git bisect next'")), + OPT_CMDMODE(0, "next-all", &cmdmode, + N_("perform 'git bisect next'"), NEXT_ALL), OPT_BOOL(0, "no-checkout", &no_checkout, N_("update BISECT_HEAD instead of checking out the current commit")), OPT_END() @@ -23,9 +23,14 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) argc = parse_options(argc, argv, prefix, options, git_bisect_helper_usage, 0); - if (!next_all) + if (!cmdmode) usage_with_options(git_bisect_helper_usage, options); - /* next-all */ - return bisect_next_all(prefix, no_checkout); + switch (cmdmode) { + case NEXT_ALL: + return bisect_next_all(prefix, no_checkout); + default: + die("BUG: unknown subcommand '%d'", cmdmode); + } + return 0; } -- 2.8.2
next prev parent reply other threads:[~2016-05-23 14:50 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-21 19:00 [PATCH] bisect--helper: convert a function in shell to C Pranit Bauva 2016-03-22 0:28 ` Stefan Beller 2016-03-22 6:10 ` Christian Couder 2016-03-22 6:13 ` Pranit Bauva 2016-03-22 6:13 ` Pranit Bauva 2016-03-22 8:01 ` [PATCH v2] " Pranit Bauva 2016-03-22 15:09 ` Johannes Schindelin 2016-03-22 15:11 ` Johannes Schindelin 2016-03-22 17:46 ` Pranit Bauva 2016-03-23 11:23 ` Johannes Schindelin 2016-03-22 16:03 ` Junio C Hamano 2016-03-22 16:49 ` Johannes Schindelin 2016-03-22 17:52 ` Pranit Bauva 2016-03-22 17:59 ` Stefan Beller 2016-03-23 11:24 ` Johannes Schindelin 2016-03-22 17:45 ` Pranit Bauva 2016-03-23 11:22 ` Johannes Schindelin 2016-03-23 13:53 ` Pranit Bauva 2016-03-23 7:16 ` [PATCH v3] " Pranit Bauva 2016-03-23 11:57 ` Johannes Schindelin 2016-03-23 13:16 ` Pranit Bauva 2016-03-23 16:24 ` Junio C Hamano 2016-03-23 18:38 ` Pranit Bauva 2016-03-23 16:15 ` Junio C Hamano 2016-03-23 18:46 ` Pranit Bauva 2016-05-04 5:07 ` [PATCH 0/2] bisect--helper: rewrite of check_term_format() Pranit Bauva 2016-05-04 5:07 ` [PATCH 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-05-04 5:34 ` Pranit Bauva 2016-05-04 6:07 ` Eric Sunshine 2016-05-04 6:50 ` Christian Couder 2016-05-04 11:05 ` Johannes Schindelin 2016-05-04 12:04 ` Pranit Bauva 2016-05-04 12:05 ` Christian Couder 2016-05-04 12:21 ` Johannes Schindelin 2016-05-04 12:41 ` Christian Couder 2016-05-04 14:56 ` Johannes Schindelin 2016-05-04 19:07 ` Christian Couder 2016-05-08 6:54 ` Johannes Schindelin 2016-05-04 7:28 ` Junio C Hamano 2016-05-04 11:02 ` Johannes Schindelin 2016-05-04 5:07 ` [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-05-04 6:52 ` Eric Sunshine 2016-05-04 7:36 ` Pranit Bauva 2016-05-04 7:40 ` Pranit Bauva 2016-05-04 8:28 ` Eric Sunshine 2016-05-04 8:54 ` Christian Couder 2016-05-04 11:58 ` Pranit Bauva 2016-05-04 17:49 ` Eric Sunshine 2016-05-04 18:08 ` Pranit Bauva 2016-05-04 11:13 ` Johannes Schindelin 2016-05-04 12:00 ` Pranit Bauva 2016-05-04 12:21 ` Christian Couder 2016-05-04 19:10 ` Junio C Hamano 2016-05-04 5:22 ` [PATCH 0/2] bisect--helper: rewrite of check_term_format() Christian Couder 2016-05-04 5:25 ` Pranit Bauva 2016-05-06 14:49 ` [PATCH v5 0/2] bisect--helper: rewrite of check-term-format() Pranit Bauva 2016-05-06 14:49 ` [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-05-08 7:04 ` Johannes Schindelin 2016-05-08 7:17 ` Pranit Bauva 2016-05-08 15:30 ` Christian Couder 2016-05-08 15:33 ` Pranit Bauva 2016-05-09 14:59 ` Johannes Schindelin 2016-05-09 15:33 ` Pranit Bauva 2016-05-06 14:49 ` [PATCH v5 2/2] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-05-07 0:05 ` Eric Sunshine 2016-05-06 22:15 ` [PATCH v5 0/2] bisect--helper: rewrite of check-term-format() Junio C Hamano 2016-05-07 13:07 ` Pranit Bauva 2016-05-08 2:25 ` Junio C Hamano 2016-05-08 6:23 ` Pranit Bauva 2016-05-08 13:34 ` Pranit Bauva 2016-05-16 0:35 ` Eric Sunshine 2016-05-16 17:07 ` Christian Couder 2016-05-20 6:59 ` Pranit Bauva 2016-05-12 5:32 ` [PATCH v6 0/3] bisect--helper: check_term_format() & write_terms() Pranit Bauva 2016-05-12 5:32 ` [PATCH v6 1/3] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-05-16 7:07 ` Eric Sunshine 2016-05-20 7:17 ` Pranit Bauva 2016-05-12 5:32 ` [PATCH v6 2/3] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-05-12 22:36 ` Junio C Hamano 2016-05-13 6:59 ` Pranit Bauva 2016-05-13 18:01 ` Junio C Hamano 2016-05-12 5:32 ` [PATCH v6 3/3] bisect--helper: `write_terms` " Pranit Bauva 2016-05-16 7:28 ` Eric Sunshine 2016-05-16 13:16 ` Johannes Schindelin 2016-05-16 15:42 ` Eric Sunshine 2016-05-16 16:45 ` Johannes Schindelin 2016-05-16 16:59 ` Eric Sunshine 2016-05-20 7:45 ` Pranit Bauva 2016-05-23 11:07 ` Johannes Schindelin 2016-05-23 13:58 ` Christian Couder 2016-05-23 15:10 ` Johannes Schindelin 2016-05-23 14:33 ` Pranit Bauva 2016-05-20 7:42 ` Pranit Bauva 2016-05-23 14:48 ` [PATCH v7 0/3] bisect--helper: check_term_format() & write_terms() Pranit Bauva 2016-05-23 14:48 ` Pranit Bauva [this message] 2016-05-23 14:48 ` [PATCH v7 2/3] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-05-23 14:48 ` [PATCH v7 3/3] bisect--helper: `write_terms` " Pranit Bauva 2016-05-23 16:01 ` Eric Sunshine 2016-05-23 17:59 ` Pranit Bauva 2016-05-24 7:21 ` [PATCH v8 0/3] bisect--helper: check-term-format() & write_terms() Pranit Bauva 2016-05-24 18:42 ` [PATCH v9 0/3] bisect--helper: check_term_format() and write_terms() Pranit Bauva 2016-05-24 18:42 ` [PATCH v9 1/3] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-05-24 18:42 ` [PATCH v9 2/3] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-05-24 18:42 ` [PATCH v9 3/3] bisect--helper: `write_terms` " Pranit Bauva 2016-05-24 7:21 ` [PATCH v8 1/3] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-05-24 7:21 ` [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-05-25 5:04 ` Johannes Schindelin 2016-05-25 5:13 ` Pranit Bauva 2016-06-16 7:10 ` Lars Schneider 2016-06-17 12:48 ` Pranit Bauva 2016-05-24 7:21 ` [PATCH v8 3/3] bisect--helper: `write_terms` " Pranit Bauva 2016-05-24 7:33 ` Christian Couder 2016-05-24 17:39 ` Junio C Hamano 2016-05-24 18:31 ` Pranit Bauva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1464014928-31548-2-git-send-email-pranit.bauva@gmail.com \ --to=pranit.bauva@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=chriscool@tuxfamily.org \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=larsxschneider@gmail.com \ --cc=sunshine@sunshineco.com \ --subject='Re: [PATCH v7 1/3] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).