From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Turner Subject: [PATCH v7 04/19] index-helper: add --strict Date: Fri, 29 Apr 2016 21:01:58 -0400 Message-ID: <1461978133-13966-5-git-send-email-dturner@twopensource.com> References: <1461978133-13966-1-git-send-email-dturner@twopensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Turner To: git@vger.kernel.org, pclouds@gmail.com X-From: git-owner@vger.kernel.org Sat Apr 30 03:03:24 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awJJb-0008GT-BQ for gcvg-git-2@plane.gmane.org; Sat, 30 Apr 2016 03:03:23 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991AbcD3BCc convert rfc822-to-quoted-printable (ORCPT ); Fri, 29 Apr 2016 21:02:32 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:34555 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752961AbcD3BC3 (ORCPT ); Fri, 29 Apr 2016 21:02:29 -0400 Received: by mail-qk0-f178.google.com with SMTP id r184so53109440qkc.1 for ; Fri, 29 Apr 2016 18:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=twopensource-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0T+HHf4OeQ5q5xaPOrfGLizmvLbAB02a9XNns8IJJHg=; b=jUkDelojZag2Wlor5zlOOWjHwBAQpKzwotGIAW1xi0IuqG4AGNpkanBxyYxIvBaPbl Vy6aCCTot/W2vMDHMaQi9lWN62hgFd47hPhT+TIwfw9w1bsul8qzo6LhvuiEI4BvvjQR XBrnH8Y1pknaOAFmhWTCpuWHcm4bIAaucrwfJy+ho4fTEhVBjBs1prpUN7/0f4SyKTSA swfkBZt2BZ3kP/N4qSHmvnsuYhp61bc8UCuadLagRm5x5xRrBiaJOp3Mxp6LBNkiNeSt GV4gTLtSuLlID+NIQR5LD+1GW/ZfvckLV5ivkDyh4arbsSOt5gsEmVBDlTyGt9cdag0H tWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0T+HHf4OeQ5q5xaPOrfGLizmvLbAB02a9XNns8IJJHg=; b=Y1ka+Q8VkzlXaPeD6Uxy1jykITt4yO1AluhiLCdj/Q58ywNkirWaccslbqzw7pS71u liOmODM9/jeGSOjMGpR0uMlI0FOh4LR+CxZc/6Leezm+lphb/ZJtJ6dvq6Z2hr/8CaCP a6JScOfQ2ChzJCtZdeXCTvht0rTfY6D0LIJpi77G0GpDc3PqO4PYhz2u03yOYxsp4hQy VLjBkanvron0MzHRPF4PJtA2QWOoetsClmwM+Jre4XILPiJI8E6+h+H0nt0ZvFXNzEHP OOq/YiiBmWm7hRjV33w5VY414a7KHXJB2qMquiHaUmGhcFodsxofKdVWOWd4aEIDbKcb vLMQ== X-Gm-Message-State: AOPr4FXhc0Pv1jOE9KKqYiC64zc7ekHZSnIin0YccxRXvPBhufl5x4r1X4h+ayGPFcc+Vg== X-Received: by 10.55.33.140 with SMTP id f12mr5779610qki.156.1461978148600; Fri, 29 Apr 2016 18:02:28 -0700 (PDT) Received: from ubuntu.twitter.biz ([192.133.79.145]) by smtp.gmail.com with ESMTPSA id g11sm5284485qhg.22.2016.04.29.18.02.27 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Apr 2016 18:02:27 -0700 (PDT) X-Mailer: git-send-email 2.4.2.767.g62658d5-twtrsrc In-Reply-To: <1461978133-13966-1-git-send-email-dturner@twopensource.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: =46rom: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy There are "holes" in the index-helper approach because the shared memory is not verified again by git. If $USER is compromised, shared memory could be modified. But anyone who could do this could already modify $GIT_DIR/index. A more realistic risk is some bugs in index-helper that produce corrupt shared memory. --strict is added to avoid that. Strictly speaking there's still a very small gap where corrupt shared memory could still be read by git: after we write the trailing SHA-1 in the shared memory (thus signaling "this shm is ready") and before verify_shm() detects an error. Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy Signed-off-by: David Turner --- Documentation/git-index-helper.txt | 9 +++++++ cache.h | 1 + index-helper.c | 48 ++++++++++++++++++++++++++++++= ++++++++ read-cache.c | 9 ++++--- 4 files changed, 64 insertions(+), 3 deletions(-) diff --git a/Documentation/git-index-helper.txt b/Documentation/git-ind= ex-helper.txt index f892184..1f92c89 100644 --- a/Documentation/git-index-helper.txt +++ b/Documentation/git-index-helper.txt @@ -25,6 +25,15 @@ OPTIONS Exit if the cached index is not accessed for `` seconds. Specify 0 to wait forever. Default is 600. =20 +--strict:: +--no-strict:: + Strict mode makes index-helper verify the shared memory after + it's created. If the result does not match what's read from + $GIT_DIR/index, the shared memory is destroyed. This makes + index-helper take more than double the amount of time required + for reading an index, but because it will happen in the + background, it's not noticable. `--strict` is enabled by default. + NOTES ----- =20 diff --git a/cache.h b/cache.h index 2d7af6f..6cb0d02 100644 --- a/cache.h +++ b/cache.h @@ -345,6 +345,7 @@ struct index_state { * on it. */ to_shm : 1, + always_verify_trailing_sha1 : 1, initialized : 1; struct hashmap name_hash; struct hashmap dir_hash; diff --git a/index-helper.c b/index-helper.c index b9443f4..bc7e110 100644 --- a/index-helper.c +++ b/index-helper.c @@ -17,6 +17,7 @@ struct shm { =20 static struct shm shm_index; static struct shm shm_base_index; +static int to_verify =3D 1; =20 static void release_index_shm(struct shm *is) { @@ -114,11 +115,56 @@ static void share_index(struct index_state *istat= e, struct shm *is) hashcpy((unsigned char *)new_mmap + istate->mmap_size - 20, is->sha1)= ; } =20 +static int verify_shm(void) +{ + int i; + struct index_state istate; + memset(&istate, 0, sizeof(istate)); + istate.always_verify_trailing_sha1 =3D 1; + istate.to_shm =3D 1; + i =3D read_index(&istate); + if (i !=3D the_index.cache_nr) + goto done; + for (; i < the_index.cache_nr; i++) { + struct cache_entry *base, *ce; + /* namelen is checked separately */ + const unsigned int ondisk_flags =3D + CE_STAGEMASK | CE_VALID | CE_EXTENDED_FLAGS; + unsigned int ce_flags, base_flags, ret; + base =3D the_index.cache[i]; + ce =3D istate.cache[i]; + if (ce->ce_namelen !=3D base->ce_namelen || + strcmp(ce->name, base->name)) { + warning("mismatch at entry %d", i); + break; + } + ce_flags =3D ce->ce_flags; + base_flags =3D base->ce_flags; + /* only on-disk flags matter */ + ce->ce_flags &=3D ondisk_flags; + base->ce_flags &=3D ondisk_flags; + ret =3D memcmp(&ce->ce_stat_data, &base->ce_stat_data, + offsetof(struct cache_entry, name) - + offsetof(struct cache_entry, ce_stat_data)); + ce->ce_flags =3D ce_flags; + base->ce_flags =3D base_flags; + if (ret) { + warning("mismatch at entry %d", i); + break; + } + } +done: + discard_index(&istate); + return i =3D=3D the_index.cache_nr; +} + static void share_the_index(void) { if (the_index.split_index && the_index.split_index->base) share_index(the_index.split_index->base, &shm_base_index); share_index(&the_index, &shm_index); + if (to_verify && !verify_shm()) + cleanup_shm(); discard_index(&the_index); } =20 @@ -247,6 +293,8 @@ int main(int argc, char **argv) struct option options[] =3D { OPT_INTEGER(0, "exit-after", &idle_in_seconds, N_("exit if not used after some seconds")), + OPT_BOOL(0, "strict", &to_verify, + "verify shared memory after creating"), OPT_END() }; =20 diff --git a/read-cache.c b/read-cache.c index 81dfb4e..9eedf03 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1671,9 +1671,12 @@ int do_read_index(struct index_state *istate, co= nst char *path, int must_exist) =20 istate->mmap =3D mmap; istate->mmap_size =3D mmap_size; - if (try_shm(istate) && - verify_hdr(istate->mmap, istate->mmap_size) < 0) - goto unmap; + if (try_shm(istate)) { + if (verify_hdr(istate->mmap, istate->mmap_size) < 0) + goto unmap; + } else if (istate->always_verify_trailing_sha1 && + verify_hdr(istate->mmap, istate->mmap_size) < 0) + goto unmap; hdr =3D mmap =3D istate->mmap; mmap_size =3D istate->mmap_size; if (!istate->keep_mmap) --=20 2.4.2.767.g62658d5-twtrsrc