From: David Turner <dturner@twopensource.com>
To: git@vger.kernel.org, pclouds@gmail.com
Cc: David Turner <dturner@twopensource.com>
Subject: [PATCH v7 17/19] index-helper: optionally automatically run
Date: Fri, 29 Apr 2016 21:02:11 -0400 [thread overview]
Message-ID: <1461978133-13966-18-git-send-email-dturner@twopensource.com> (raw)
In-Reply-To: <1461978133-13966-1-git-send-email-dturner@twopensource.com>
Introduce a new config option, indexhelper.autorun, to automatically
run git index-helper before starting up a builtin git command. This
enables users to keep index-helper running without manual
intervention.
Signed-off-by: David Turner <dturner@twopensource.com>
---
Documentation/config.txt | 4 ++++
read-cache.c | 37 +++++++++++++++++++++++++++++++++++--
t/t7900-index-helper.sh | 19 +++++++++++++++++++
3 files changed, 58 insertions(+), 2 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 15001ce..385ea66 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1856,6 +1856,10 @@ index.version::
Specify the version with which new index files should be
initialized. This does not affect existing repositories.
+indexhelper.autorun::
+ Automatically run git index-helper when any builtin git
+ command is run inside a repository.
+
init.templateDir::
Specify the directory from which templates will be copied.
(See the "TEMPLATE DIRECTORY" section of linkgit:git-init[1].)
diff --git a/read-cache.c b/read-cache.c
index 5f5e933..99eeee4 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -21,6 +21,7 @@
#include "unix-socket.h"
#include "pkt-line.h"
#include "ewah/ewok.h"
+#include "run-command.h"
static struct cache_entry *refresh_cache_entry(struct cache_entry *ce,
unsigned int options);
@@ -1723,6 +1724,33 @@ static void post_read_index_from(struct index_state *istate)
tweak_untracked_cache(istate);
}
+static int want_auto_index_helper(void)
+{
+ int want = -1;
+ const char *value = NULL;
+ const char *key = "indexhelper.autorun";
+
+ if (git_config_key_is_valid(key) &&
+ !git_config_get_value(key, &value)) {
+ int b = git_config_maybe_bool(key, value);
+ want = b >= 0 ? b : 0;
+ }
+ return want;
+}
+
+static void autorun_index_helper(void)
+{
+ const char *argv[] = {"git-index-helper", "--detach", "--autorun", NULL};
+ if (want_auto_index_helper() <= 0)
+ return;
+
+ trace_argv_printf(argv, "trace: auto index-helper:");
+
+ if (run_command_v_opt(argv,
+ RUN_SILENT_EXEC_FAILURE | RUN_CLEAN_ON_EXIT))
+ warning(_("You specified indexhelper.autorun, but running git-index-helper failed."));
+}
+
/* in ms */
#define WATCHMAN_TIMEOUT 1000
@@ -1796,6 +1824,7 @@ static int poke_daemon(struct index_state *istate,
if (fd < 0) {
warning("Failed to connect to index-helper socket");
unlink(git_path("index-helper.sock"));
+ autorun_index_helper();
return -1;
}
@@ -1833,9 +1862,13 @@ static int try_shm(struct index_state *istate)
int fd = -1;
if (!is_main_index(istate) ||
- old_size <= 20 ||
- stat(git_path("index-helper.sock"), &st))
+ old_size <= 20)
return -1;
+
+ if (stat(git_path("index-helper.sock"), &st)) {
+ autorun_index_helper();
+ return -1;
+ }
if (poke_daemon(istate, &st, 0))
return -1;
sha1 = (unsigned char *)istate->mmap + old_size - 20;
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
index aa6e5fc..2d3ce3c 100755
--- a/t/t7900-index-helper.sh
+++ b/t/t7900-index-helper.sh
@@ -16,6 +16,9 @@ test -n "$NO_MMAP" && {
}
test_expect_success 'index-helper smoke test' '
+ # We need an existing commit so that the index exists (otherwise,
+ # the index-helper will not be autostarted)
+ test_commit x &&
git index-helper --exit-after 1 &&
test_path_is_missing .git/index-helper.sock
'
@@ -46,4 +49,20 @@ test_expect_success 'index-helper is quiet with --autorun' '
git index-helper --autorun
'
+test_expect_success 'index-helper autorun works' '
+ rm -f .git/index-helper.sock &&
+ git status &&
+ test_path_is_missing .git/index-helper.sock &&
+ test_config indexhelper.autorun true &&
+ git status &&
+ test -S .git/index-helper.sock &&
+ git status 2>err &&
+ test -S .git/index-helper.sock &&
+ ! grep -q . err &&
+ git index-helper --kill &&
+ test_config indexhelper.autorun false &&
+ git status &&
+ test_path_is_missing .git/index-helper.sock
+'
+
test_done
--
2.4.2.767.g62658d5-twtrsrc
next prev parent reply other threads:[~2016-04-30 1:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 1:01 [PATCH v7 00/19] index-helper/watchman David Turner
2016-04-30 1:01 ` [PATCH v7 01/19] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-30 1:01 ` [PATCH v7 02/19] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-30 1:01 ` [PATCH v7 03/19] index-helper: new daemon for caching index and related stuff David Turner
2016-04-30 1:01 ` [PATCH v7 04/19] index-helper: add --strict David Turner
2016-04-30 1:01 ` [PATCH v7 05/19] index-helper: log warnings David Turner
2016-04-30 1:02 ` [PATCH v7 06/19] daemonize(): set a flag before exiting the main process David Turner
2016-04-30 1:02 ` [PATCH v7 07/19] index-helper: add --detach David Turner
2016-04-30 1:02 ` [PATCH v7 08/19] read-cache: add watchman 'WAMA' extension David Turner
2016-04-30 1:02 ` [PATCH v7 09/19] Add watchman support to reduce index refresh cost David Turner
2016-04-30 1:02 ` [PATCH v7 10/19] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-30 1:02 ` [PATCH v7 11/19] update-index: enable/disable watchman support David Turner
2016-04-30 1:02 ` [PATCH v7 12/19] unpack-trees: preserve index extensions David Turner
2016-04-30 1:02 ` [PATCH v7 13/19] watchman: add a config option to enable the extension David Turner
2016-04-30 1:02 ` [PATCH v7 14/19] index-helper: kill mode David Turner
2016-04-30 1:02 ` [PATCH v7 15/19] index-helper: don't run if already running David Turner
2016-04-30 1:02 ` [PATCH v7 16/19] index-helper: autorun mode David Turner
2016-04-30 1:02 ` David Turner [this message]
2016-04-30 1:02 ` [PATCH v7 18/19] Add tracing to measure where most of the time is spent David Turner
2016-04-30 1:02 ` [PATCH v7 19/19] untracked-cache: config option David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461978133-13966-18-git-send-email-dturner@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).