From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: jacob.keller@gmail.com, gitster@pobox.com, peff@peff.net,
Karthik Nayak <Karthik.188@gmail.com>
Subject: [PATCH v5b 02/17] ref-filter: include reference to 'used_atom' within 'atom_value'
Date: Mon, 25 Apr 2016 20:47:43 +0530 [thread overview]
Message-ID: <1461597478-31855-2-git-send-email-Karthik.188@gmail.com> (raw)
In-Reply-To: <1461581558-32348-1-git-send-email-Karthik.188@gmail.com>
Ensure that each 'atom_value' has a reference to its corresponding
'used_atom'. This let's us use values within 'used_atom' in the
'handler' function.
Hence we can get the %(align) atom's parameters directly from the
'used_atom' therefore removing the necessity of passing %(align) atom's
parameters to 'atom_value'.
This also acts as a preparatory patch for the upcoming patch where we
introduce %(if:equals=) and %(if:notequals=).
Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
---
ref-filter.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 41e73f0..12e646c 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -230,11 +230,9 @@ struct ref_formatting_state {
struct atom_value {
const char *s;
- union {
- struct align align;
- } u;
void (*handler)(struct atom_value *atomv, struct ref_formatting_state *state);
unsigned long ul; /* used for sorting when not FIELD_STR */
+ struct used_atom *atom;
};
/*
@@ -370,7 +368,7 @@ static void align_atom_handler(struct atom_value *atomv, struct ref_formatting_s
push_stack_element(&state->stack);
new = state->stack;
new->at_end = end_align_handler;
- new->at_end_data = &atomv->u.align;
+ new->at_end_data = &atomv->atom->u.align;
}
static void if_then_else_handler(struct ref_formatting_stack **stack)
@@ -1069,6 +1067,7 @@ static void populate_value(struct ref_array_item *ref)
struct branch *branch = NULL;
v->handler = append_atom;
+ v->atom = atom;
if (*name == '*') {
deref = 1;
@@ -1133,7 +1132,6 @@ static void populate_value(struct ref_array_item *ref)
v->s = " ";
continue;
} else if (starts_with(name, "align")) {
- v->u.align = atom->u.align;
v->handler = align_atom_handler;
continue;
} else if (!strcmp(name, "end")) {
--
2.8.0
next prev parent reply other threads:[~2016-04-25 15:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 10:52 [PATCH v5b 00/17] port branch.c to use ref-filter's printing options Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 01/17] ref-filter: implement %(if), %(then), and %(else) atoms Karthik Nayak
2016-04-25 15:17 ` Karthik Nayak [this message]
2016-04-25 15:17 ` [PATCH v5b 03/17] ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>) Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 04/17] ref-filter: modify "%(objectname:short)" to take length Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 05/17] ref-filter: move get_head_description() from branch.c Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 06/17] ref-filter: introduce format_ref_array_item() Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 07/17] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 08/17] ref-filter: add support for %(upstream:track,nobracket) Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 09/17] ref-filter: make "%(symref)" atom work with the ':short' modifier Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 10/17] ref-filter: introduce refname_atom_parser_internal() Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 11/17] ref-filter: introduce symref_atom_parser() and refname_atom_parser() Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 12/17] ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal() Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 13/17] ref-filter: add `:dir` and `:base` options for ref printing atoms Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 14/17] ref-filter: allow porcelain to translate messages in the output Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 15/17] branch, tag: use porcelain output Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 16/17] branch: use ref-filter printing APIs Karthik Nayak
2016-04-25 15:17 ` [PATCH v5b 17/17] branch: implement '--format' option Karthik Nayak
2016-04-25 21:47 ` [PATCH v5b 00/17] port branch.c to use ref-filter's printing options Junio C Hamano
2016-04-26 18:21 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461597478-31855-2-git-send-email-Karthik.188@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).