git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, jacob.keller@gmail.com,
	Stefan Beller <sbeller@google.com>
Subject: [PATCHv4 0/6] Fix path bugs in submodule commands executed from sub dir
Date: Tue, 29 Mar 2016 18:27:40 -0700	[thread overview]
Message-ID: <1459301266-12403-1-git-send-email-sbeller@google.com> (raw)

v4:
* addressed Junios comments in patch 1&2, which is:
1)
    * reworded commit message
    * when writing the commit message I discovered a new way to fix the bug
      (fix the computation of the displaypath instead of its parameters
       wt_prefix and prefix.)
    
      The result is the same, but I am not yet sure if I like it more.

2)
    * Use `git -C <path>` instead of `cd <path> && git`.
    * Reword commit message

v3:
Resending without `test_pause` in the last test.

v2:

The first 3 commits are
* Test and bugfix in one commit each
* better explained than before

The expansion of an expected test result moved to the back of the series.

There are two new commits
* one being another bugfix of the display path for `submodule update`
* another test for `submodule update` as I suspect it may break further on
  refactoring and we currently have no tests for it.

Thanks,
Stefan

Stefan Beller (6):
  submodule foreach: correct path display in recursive submodules
  submodule update --init: correct path handling in recursive submodules
  submodule status: correct path handling in recursive submodules
  submodule update: align reporting path for custom command execution
  submodule update: test recursive path reporting from subdirectory
  t7407: make expectation as clear as possible

 git-submodule.sh             | 13 +++----
 t/t7406-submodule-update.sh  | 82 ++++++++++++++++++++++++++++++++++++++++++--
 t/t7407-submodule-foreach.sh | 49 ++++++++++++++++++++++++--
 3 files changed, 133 insertions(+), 11 deletions(-)

-- 
2.8.0.2.gb331331

             reply	other threads:[~2016-03-30  1:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  1:27 Stefan Beller [this message]
2016-03-30  1:27 ` [PATCHv4 1/6] submodule foreach: correct path display in recursive submodules Stefan Beller
2016-03-30 20:05   ` Junio C Hamano
2016-03-30  1:27 ` [PATCHv4 2/6] submodule update --init: correct path handling " Stefan Beller
2016-03-30  1:27 ` [PATCHv4 3/6] submodule status: " Stefan Beller
2016-03-30  1:27 ` [PATCHv4 4/6] submodule update: align reporting path for custom command execution Stefan Beller
2016-03-30  1:27 ` [PATCHv4 5/6] submodule update: test recursive path reporting from subdirectory Stefan Beller
2016-03-30  1:27 ` [PATCHv4 6/6] t7407: make expectation as clear as possible Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459301266-12403-1-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacob.keller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).