From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: pclouds@gmail.com, Jens.Lehmann@web.de, jacob.keller@gmail.com,
sunshine@sunshineco.com, Stefan Beller <sbeller@google.com>
Subject: [PATCHv3 0/5] submodule helper: cleanup prefix passing
Date: Fri, 25 Mar 2016 11:39:11 -0700 [thread overview]
Message-ID: <1458931156-29125-1-git-send-email-sbeller@google.com> (raw)
Thanks Junio for the in-depth discussion!
I squashed the first two commits as they are actually fixing the same underlying
issue. Setting wt_prefix=<empty> is the actual preparation for switching
the submodule--helper to git -C instead of "--prefix$prefix".
But setting wt_prefix=empty would break existing tests, so the different
computation of the prefix (relative_path of sm_path instead of plain sm_path)
is the fix of the fix.
Eric, I picked up the git -C in the tests, which are broken into 2 patches and
have a more concise commit message each.
Jacob, thanks for your
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
although I changed the code so much, that I did not put it in this series.
New in this series is the last commit, which gets rid of the prefix for
"submodule--helper clone". (It was useless to begin with; probably just
cargo-culted in because we had it in "submodule--helper list")
Thanks,
Stefan
Stefan Beller (5):
submodule: prepare recursive path from non root directory
submodule--helper list: lose the extra prefix option
submodule update: add test for recursive from non root dir
submodule sync: test syncing one submodule
submodule--helper clone: lose the extra prefix option
builtin/submodule--helper.c | 10 ++--------
git-submodule.sh | 23 +++++++++++++----------
t/t7403-submodule-sync.sh | 13 +++++++++----
t/t7406-submodule-update.sh | 14 +++++++++++---
4 files changed, 35 insertions(+), 25 deletions(-)
--
2.8.0.rc4.10.g52f3f33.dirty
next reply other threads:[~2016-03-25 18:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 18:39 Stefan Beller [this message]
2016-03-25 18:39 ` [PATCHv3 1/5] submodule: prepare recursive path from non root directory Stefan Beller
2016-03-25 19:21 ` Junio C Hamano
2016-03-25 18:39 ` [PATCHv3 2/5] submodule--helper list: lose the extra prefix option Stefan Beller
2016-03-25 18:39 ` [PATCHv3 3/5] submodule update: add test for recursive from non root dir Stefan Beller
2016-03-25 18:39 ` [PATCHv3 4/5] submodule sync: test syncing one submodule Stefan Beller
2016-03-25 18:39 ` [PATCHv3 5/5] submodule--helper clone: lose the extra prefix option Stefan Beller
2016-03-25 19:41 ` Junio C Hamano
2016-03-25 20:54 ` Junio C Hamano
2016-03-25 22:09 ` Stefan Beller
2016-03-25 22:39 ` Junio C Hamano
2016-03-25 23:02 ` Stefan Beller
2016-03-25 23:15 ` Junio C Hamano
2016-03-25 23:51 ` Stefan Beller
2016-03-28 16:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458931156-29125-1-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).