From: Jacob Nisnevich <jacob.nisnevich@gmail.com>
To: davvid@gmail.com
Cc: gitster@pobox.com, git@vger.kernel.org,
Jacob Nisnevich <jacob.nisnevich@gmail.com>
Subject: [PATCH 2/2] created helper function for both winmerge and examdiff mergetools
Date: Tue, 22 Mar 2016 17:43:14 -0700 [thread overview]
Message-ID: <1458693794-9124-3-git-send-email-jacob.nisnevich@gmail.com> (raw)
In-Reply-To: <1458693794-9124-1-git-send-email-jacob.nisnevich@gmail.com>
Signed-off-by: Jacob Nisnevich <jacob.nisnevich@gmail.com>
---
...s-created-new-mergetool-file-for-ExamDiff.patch | 58 ++++++++++++++++++++++
mergetools/examdiff | 25 ++--------
mergetools/mergetools_helpers | 30 +++++++++++
mergetools/winmerge | 23 ++-------
4 files changed, 95 insertions(+), 41 deletions(-)
create mode 100644 0001-mergetools-created-new-mergetool-file-for-ExamDiff.patch
create mode 100644 mergetools/mergetools_helpers
diff --git a/0001-mergetools-created-new-mergetool-file-for-ExamDiff.patch b/0001-mergetools-created-new-mergetool-file-for-ExamDiff.patch
new file mode 100644
index 0000000..99e0d6b
--- /dev/null
+++ b/0001-mergetools-created-new-mergetool-file-for-ExamDiff.patch
@@ -0,0 +1,58 @@
+From a26ad589bc5e747962359c89c5536858748e5eb8 Mon Sep 17 00:00:00 2001
+From: Jacob Nisnevich <jacob.nisnevich@gmail.com>
+Date: Sat, 19 Mar 2016 17:31:50 -0700
+Subject: [PATCH] mergetools: created new mergetool file for ExamDiff
+To: git@vger.kernel.org
+
+---
+ mergetools/examdiff | 37 +++++++++++++++++++++++++++++++++++++
+ 1 file changed, 37 insertions(+)
+ create mode 100644 mergetools/examdiff
+
+diff --git a/mergetools/examdiff b/mergetools/examdiff
+new file mode 100644
+index 0000000..474fffe
+--- /dev/null
++++ b/mergetools/examdiff
+@@ -0,0 +1,37 @@
++diff_cmd () {
++ "$merge_tool_path" "$LOCAL" "$REMOTE" -nh
++}
++
++merge_cmd () {
++ touch "$BACKUP"
++ if $base_present
++ then
++ "$merge_tool_path" -merge "$LOCAL" "$BASE" "$REMOTE" -o:"$MERGED" -nh
++ else
++ "$merge_tool_path" -merge "$LOCAL" "$REMOTE" -o:"$MERGED" -nh
++ fi
++ check_unchanged
++}
++
++translate_merge_tool_path() {
++ # Use ExamDiff.com if it exists in $PATH
++ if type -p ExamDiff.com >/dev/null 2>&1
++ then
++ printf ExamDiff.com
++ return
++ fi
++
++ # Look for ExamDiff.com in the typical locations
++ examdiff="ExamDiff Pro/ExamDiff.com"
++ for directory in $(env | grep -Ei '^PROGRAM(FILES(\(X86\))?|W6432)=' |
++ cut -d '=' -f 2- | sort -u)
++ do
++ if test -n "$directory" && test -x "$directory/$examdiff"
++ then
++ printf '%s' "$directory/$examdiff"
++ return
++ fi
++ done
++
++ printf ExamDiff.com
++}
+\ No newline at end of file
+--
+1.9.1
+
diff --git a/mergetools/examdiff b/mergetools/examdiff
index 474fffe..8b66c17 100644
--- a/mergetools/examdiff
+++ b/mergetools/examdiff
@@ -1,3 +1,5 @@
+. mergetools_helpers
+
diff_cmd () {
"$merge_tool_path" "$LOCAL" "$REMOTE" -nh
}
@@ -14,24 +16,5 @@ merge_cmd () {
}
translate_merge_tool_path() {
- # Use ExamDiff.com if it exists in $PATH
- if type -p ExamDiff.com >/dev/null 2>&1
- then
- printf ExamDiff.com
- return
- fi
-
- # Look for ExamDiff.com in the typical locations
- examdiff="ExamDiff Pro/ExamDiff.com"
- for directory in $(env | grep -Ei '^PROGRAM(FILES(\(X86\))?|W6432)=' |
- cut -d '=' -f 2- | sort -u)
- do
- if test -n "$directory" && test -x "$directory/$examdiff"
- then
- printf '%s' "$directory/$examdiff"
- return
- fi
- done
-
- printf ExamDiff.com
-}
\ No newline at end of file
+ mergetool_find_win32_cmd "ExamDiff.com" "ExamDiff Pro"
+}
diff --git a/mergetools/mergetools_helpers b/mergetools/mergetools_helpers
new file mode 100644
index 0000000..6df9d09
--- /dev/null
+++ b/mergetools/mergetools_helpers
@@ -0,0 +1,30 @@
+# Find path to win32 executable using typical locations
+# Arguments
+# executable - default name of executable file
+# folder - folder containing executable file from Program Files
+# Returns
+# Path to the executable
+mergetool_find_win32_cmd () {
+ executable = $1
+ folder = $2
+
+ # Use executable.com if it exists in $PATH
+ if type -p $executable >/dev/null 2>&1
+ then
+ printf $executable
+ return
+ fi
+
+ # Look for executable in the typical locations
+ for directory in $(env | grep -Ei '^PROGRAM(FILES(\(X86\))?|W6432)=' |
+ cut -d '=' -f 2- | sort -u)
+ do
+ if test -n "$directory" && test -x "$directory/$folder/$executable"
+ then
+ printf '%s' "$directory/$folder/$executable"
+ return
+ fi
+ done
+
+ printf $executable
+}
diff --git a/mergetools/winmerge b/mergetools/winmerge
index 74a66d4..265d853 100644
--- a/mergetools/winmerge
+++ b/mergetools/winmerge
@@ -1,3 +1,5 @@
+. mergetools_helpers
+
diff_cmd () {
"$merge_tool_path" -u -e "$LOCAL" "$REMOTE"
return 0
@@ -13,24 +15,5 @@ merge_cmd () {
}
translate_merge_tool_path() {
- # Use WinMergeU.exe if it exists in $PATH
- if type -p WinMergeU.exe >/dev/null 2>&1
- then
- printf WinMergeU.exe
- return
- fi
-
- # Look for WinMergeU.exe in the typical locations
- winmerge_exe="WinMerge/WinMergeU.exe"
- for directory in $(env | grep -Ei '^PROGRAM(FILES(\(X86\))?|W6432)=' |
- cut -d '=' -f 2- | sort -u)
- do
- if test -n "$directory" && test -x "$directory/$winmerge_exe"
- then
- printf '%s' "$directory/$winmerge_exe"
- return
- fi
- done
-
- printf WinMergeU.exe
+ mergetool_find_win32_cmd "WinMergeU.exe" "WinMerge"
}
--
1.9.1
next prev parent reply other threads:[~2016-03-23 0:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 4:58 [PATCH] mergetools: created new mergetool file for ExamDiff Jacob Nisnevich
2016-03-21 1:02 ` Junio C Hamano
2016-03-21 3:32 ` David Aguilar
2016-03-23 0:43 ` [PATCH 0/2] Helper function for ExamDiff and Winmerge mergetools Jacob Nisnevich
2016-03-23 0:43 ` [PATCH 1/2] mergetools: created new mergetool file for ExamDiff Jacob Nisnevich
2016-03-23 0:43 ` Jacob Nisnevich [this message]
2016-03-23 2:41 ` [PATCH 2/2] created helper function for both winmerge and examdiff mergetools Junio C Hamano
2016-03-23 22:55 ` [PATCH] mergetools: implemented new mergetool file for ExamDiff Jacob Nisnevich
2016-03-23 22:55 ` Jacob Nisnevich
2016-03-24 7:44 ` David Aguilar
2016-03-24 15:43 ` Junio C Hamano
2016-03-25 22:52 ` [PATCH 0/2] add support " Jacob Nisnevich
2016-03-25 22:52 ` [PATCH 1/2] mergetools: create mergetool_find_win32_cmd() helper function for winmerge Jacob Nisnevich
2016-03-25 23:00 ` Junio C Hamano
2016-03-25 23:17 ` [PATCH 0/2] mergetools: add support for ExamDiff Jacob Nisnevich
2016-03-25 23:17 ` [PATCH 1/2] mergetools: create mergetool_find_win32_cmd() helper function for winmerge Jacob Nisnevich
2016-03-25 23:17 ` [PATCH 2/2] mergetools: add support for ExamDiff Jacob Nisnevich
2016-04-01 18:10 ` [PATCH 0/2] " Junio C Hamano
2016-04-02 21:02 ` David Aguilar
2016-03-25 22:52 ` [PATCH 2/2] " Jacob Nisnevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458693794-9124-3-git-send-email-jacob.nisnevich@gmail.com \
--to=jacob.nisnevich@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).