From: David Turner <dturner@twopensource.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: git mailing list <git@vger.kernel.org>,
mhagger@alum.mit.edu, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 25/27] refs: add LMDB refs storage backend
Date: Wed, 24 Feb 2016 15:43:40 -0500 [thread overview]
Message-ID: <1456346620.18017.23.camel@twopensource.com> (raw)
In-Reply-To: <20160220025826.GA9338@lanh>
On Sat, 2016-02-20 at 09:58 +0700, Duy Nguyen wrote:
> > On Fri, 2016-02-19 at 09:54 +0700, Duy Nguyen wrote:
> > > On Fri, Feb 19, 2016 at 3:23 AM, David Turner <
> > > dturner@twopensource.com> wrote:
> > > > > > +static int read_per_worktree_ref(const char *submodule,
> > > > > > const
> > > > > > char
> > > > > > *refname,
> > > > > > + struct MDB_val *val, int
> > > > > > *needs_free)
> > > > >
> > > > > From what I read, I suspect these _per_worktree functions
> > > > > will be
> > > > > identical for the next backend. Should we just hand over the
> > > > > job
> > > > > for
> > > > > files backend? For all entry points that may deal with per
> > > > > -worktree
> > > > > refs, e.g. lmdb_resolve_ref_unsafe, can we check ref_type()
> > > > > first
> > > > > thing, if it's per-worktree we call
> > > > > refs_be_files.resolve_ref_unsafe()
> > > > > instead? It could even be done at frontend level,
> > > > > e.g. refs.c:resolve_ref_unsafe().
> > > > >
> > > > > Though I may be talking rubbish here because I don't know how
> > > > > whether
> > > > > it has anything to do with transactions.
> > > >
> > > > The reason I did it this way is that some ref chains cross
> > > > backend
> > > > boundaries (e.g. HEAD -> refs/heads/master). But if we have
> > > > other
> > > > backends later, we could generalize.
> > >
> > > Crossing backends should go through frontend again, imo. But I
> > > don't
> > > really know if it's efficient.
> >
> > It's pretty tricky to maintain state (e.g. count of symref
> > redirects)
> > across that barrier. So I'm not sure how to do it cleanly.
>
> I notice files backend does pretty much the same thing. "files"
> backend looks more like two backends combined in one, one is files,
> the other is packed-refs. And it looks like we could solve it by
> providing a lower level api, read_raw_ref() or something, that
> retrieves the ref without any validation or link following. More on
> this later.
That basica pproach appears to mostly work. I'll send another series
with read_raw_ref as soon as I'm done applying all comments on this
series.
> > > > > I'm not sure I get this comment. D/F conflicts are no longer
> > > > > a
> > > > > thing
> > > > > for lmdb backend, right?
> > > >
> > > > I'm trying to avoid the lmdb backend creating a set of refs
> > > > that
> > > > the
> > > > files backend can't handle. This would make collaboration with
> > > > other
> > > > versions of git more difficult.
> > >
> > > It already is. If you create refs "foo" and "FOO" on case
> > > sensitive
> > > file system and clone it on a case-insensitive one, you face the
> > > same
> > > problem. We may have an optional configuration knob to prevent
> > > incompatibilities with files backend, but I think that should be
> > > done
> > > (and enforced if necessary) outside backends.
> >
> > Sure, the current state isn't perfect, but why make it worse?
>
> I see it from a different angle. The current state isn't perfect, but
> we will be moving to a better future where "files" backend may
> eventually be deprecated. Why hold back?
>
> But this line of reasoning only works if we have a new backend
> capable
> of replacing "files" without regressions or introducing new
> dependency. Which is why I suggest a new backend [1] (or implement
> Shawn's RefTree if it's proven as good with small repos)
>
> I have no problem if you want to stay strictly compatible with
> "files"
> though.
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/285893/foc
> us=286654
Won't RefTree have the same d/f conflict issue?
> OK how about we keep resolve_ref_1() whole and split real backend
> code
> out? Something like these three patches (only built, did not test). A
> bit ugly with continue_symlink, but it's just demonstration.
I did this a somewhat different way -- will see what you think when I
send it.
next prev parent reply other threads:[~2016-02-24 20:43 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 5:17 [PATCH v5 00/27] refs backends David Turner
2016-02-18 5:17 ` [PATCH v5 01/27] refs: Move head_ref{,_submodule} to the common code David Turner
2016-02-18 5:17 ` [PATCH v5 02/27] refs: move for_each_*ref* functions into " David Turner
2016-02-18 5:17 ` [PATCH v5 03/27] refs: add a backend method structure with transaction functions David Turner
2016-02-18 5:17 ` [PATCH v5 04/27] refs: add methods for misc ref operations David Turner
2016-02-18 5:17 ` [PATCH v5 05/27] refs: add method for do_for_each_ref David Turner
2016-02-18 5:17 ` [PATCH v5 06/27] refs: add do_for_each_per_worktree_ref David Turner
2016-02-18 5:17 ` [PATCH v5 07/27] refs: add methods for reflog David Turner
2016-02-18 5:17 ` [PATCH v5 08/27] refs: add method for initial ref transaction commit David Turner
2016-02-18 5:17 ` [PATCH v5 09/27] refs: add method for delete_refs David Turner
2016-02-18 5:17 ` [PATCH v5 10/27] refs: add methods to init refs db David Turner
2016-02-18 5:17 ` [PATCH v5 11/27] refs: add method to rename refs David Turner
2016-02-18 5:17 ` [PATCH v5 12/27] refs: forbid cross-backend ref renames David Turner
2016-02-20 4:30 ` Duy Nguyen
2016-02-24 20:48 ` David Turner
2016-02-18 5:17 ` [PATCH v5 13/27] refs: make lock generic David Turner
2016-02-18 5:17 ` [PATCH v5 14/27] refs: move duplicate check to common code David Turner
2016-02-18 5:17 ` [PATCH v5 15/27] refs: allow log-only updates David Turner
2016-02-18 5:17 ` [PATCH v5 16/27] refs: don't dereference on rename David Turner
2016-02-18 5:17 ` [PATCH v5 17/27] refs: on symref reflog expire, lock symref not referrent David Turner
2016-02-18 5:17 ` [PATCH v5 18/27] refs: resolve symbolic refs first David Turner
2016-02-18 5:17 ` [PATCH v5 19/27] refs: always handle non-normal refs in files backend David Turner
2016-02-18 5:17 ` [PATCH v5 20/27] init: allow alternate ref strorage to be set for new repos David Turner
2016-02-18 5:17 ` [PATCH v5 21/27] refs: check submodules' ref storage config David Turner
2016-02-18 5:17 ` [PATCH v5 22/27] clone: allow ref storage backend to be set for clone David Turner
2016-02-18 5:17 ` [PATCH v5 23/27] svn: learn ref-storage argument David Turner
2016-02-20 23:55 ` Eric Wong
2016-02-23 18:08 ` David Turner
2016-02-18 5:17 ` [PATCH v5 24/27] refs: add register_ref_storage_backends() David Turner
2016-02-18 5:17 ` [PATCH v5 25/27] refs: add LMDB refs storage backend David Turner
2016-02-18 8:50 ` Duy Nguyen
2016-02-18 20:23 ` David Turner
2016-02-18 21:15 ` Junio C Hamano
2016-02-19 2:54 ` Duy Nguyen
2016-02-19 19:10 ` David Turner
2016-02-20 13:14 ` Duy Nguyen
2016-02-24 20:41 ` David Turner
2016-02-20 21:32 ` Junio C Hamano
2016-02-19 22:49 ` David Turner
2016-02-19 23:08 ` Junio C Hamano
2016-02-20 2:58 ` Duy Nguyen
2016-02-24 20:43 ` David Turner [this message]
2016-02-25 10:07 ` Duy Nguyen
2016-02-20 8:59 ` Duy Nguyen
2016-02-24 20:37 ` David Turner
2016-02-25 10:12 ` Duy Nguyen
2016-02-25 20:05 ` [PATCH] refs: document transaction semantics David Turner
2016-02-25 20:10 ` David Turner
2016-02-25 20:34 ` Junio C Hamano
2016-02-25 20:50 ` David Turner
2016-02-18 5:17 ` [PATCH v5 26/27] refs: tests for lmdb backend David Turner
2016-02-18 5:17 ` [PATCH v5 27/27] tests: add ref-storage argument David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456346620.18017.23.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).