git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, jrnieder@gmail.com, Jens.Lehmann@web.de,
	Stefan Beller <sbeller@google.com>
Subject: [PATCHv12 0/7]  Expose submodule parallelism to the user
Date: Thu, 18 Feb 2016 14:19:17 -0800	[thread overview]
Message-ID: <1455833964-3629-1-git-send-email-sbeller@google.com> (raw)

Thanks Junio for a review of v11!

I addressed the memory issue with the interdiff (in patch 1/7) as follows:
Interdiff to v11:

diff --git a/submodule.c b/submodule.c
index 263cb2a..45d0967 100644
--- a/submodule.c
+++ b/submodule.c
@@ -219,6 +219,9 @@ void gitmodules_config(void)
 int parse_submodule_update_strategy(const char *value,
                struct submodule_update_strategy *dst)
 {
+       const char *com;
+
+       free((void*)dst->command);
        dst->command = NULL;
        if (!strcmp(value, "none"))
                dst->type = SM_UPDATE_NONE;
@@ -228,9 +231,10 @@ int parse_submodule_update_strategy(const char *value,
                dst->type = SM_UPDATE_REBASE;
        else if (!strcmp(value, "merge"))
                dst->type = SM_UPDATE_MERGE;
-       else if (skip_prefix(value, "!", &dst->command))
+       else if (skip_prefix(value, "!", &com)) {
                dst->type = SM_UPDATE_COMMAND;
-       else
+               dst->command = xstrdup(com);
+       } else
                return -1;
        return 0;
 }

Stefan Beller (7):
  submodule-config: keep update strategy around
  submodule-config: drop check against NULL
  fetching submodules: respect `submodule.fetchJobs` config option
  submodule update: direct error message to stderr
  git submodule update: have a dedicated helper for cloning
  submodule update: expose parallelism to the user
  clone: allow an explicit argument for parallel submodule clones

 Documentation/config.txt        |   6 +
 Documentation/git-clone.txt     |   6 +-
 Documentation/git-submodule.txt |   7 +-
 builtin/clone.c                 |  19 +++-
 builtin/fetch.c                 |   2 +-
 builtin/submodule--helper.c     | 239 ++++++++++++++++++++++++++++++++++++++++
 git-submodule.sh                |  54 ++++-----
 submodule-config.c              |  18 ++-
 submodule-config.h              |   2 +
 submodule.c                     |  39 ++++++-
 submodule.h                     |  18 +++
 t/t5526-fetch-submodules.sh     |  14 +++
 t/t7400-submodule-basic.sh      |   4 +-
 t/t7406-submodule-update.sh     |  27 +++++
 14 files changed, 406 insertions(+), 49 deletions(-)

-- 
2.7.0.rc0.34.g65aed89

             reply	other threads:[~2016-02-18 22:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 22:19 Stefan Beller [this message]
2016-02-18 22:19 ` [PATCHv12 1/7] submodule-config: keep update strategy around Stefan Beller
2016-02-18 22:19 ` [PATCHv12 2/7] submodule-config: drop check against NULL Stefan Beller
2016-02-18 22:19 ` [PATCHv12 3/7] fetching submodules: respect `submodule.fetchJobs` config option Stefan Beller
2016-02-18 22:19 ` [PATCHv12 4/7] submodule update: direct error message to stderr Stefan Beller
2016-02-18 22:19 ` [PATCHv12 5/7] git submodule update: have a dedicated helper for cloning Stefan Beller
2016-02-18 22:19 ` [PATCHv12 6/7] submodule update: expose parallelism to the user Stefan Beller
2016-02-18 22:19 ` [PATCHv12 7/7] clone: allow an explicit argument for parallel submodule clones Stefan Beller
2016-02-18 22:55 ` [PATCHv12 0/7] Expose submodule parallelism to the user Junio C Hamano
2016-02-18 23:12   ` Stefan Beller
2016-02-18 23:14     ` Stefan Beller
2016-02-18 23:20       ` Junio C Hamano
2016-02-18 23:27         ` Stefan Beller
2016-02-19  3:14           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455833964-3629-1-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).