git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 04/10] t/t6015-rev-list-show-all-parents.sh: use the $( ... ) construct for command substitution
Date: Thu,  7 Jan 2016 14:51:44 +0100	[thread overview]
Message-ID: <1452174710-28188-5-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1452174710-28188-1-git-send-email-gitter.spiros@gmail.com>

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t6015-rev-list-show-all-parents.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/t6015-rev-list-show-all-parents.sh b/t/t6015-rev-list-show-all-parents.sh
index 8b146fb..3c73c93 100755
--- a/t/t6015-rev-list-show-all-parents.sh
+++ b/t/t6015-rev-list-show-all-parents.sh
@@ -6,11 +6,11 @@ test_description='--show-all --parents does not rewrite TREESAME commits'
 
 test_expect_success 'set up --show-all --parents test' '
 	test_commit one foo.txt &&
-	commit1=`git rev-list -1 HEAD` &&
+	commit1=$(git rev-list -1 HEAD) &&
 	test_commit two bar.txt &&
-	commit2=`git rev-list -1 HEAD` &&
+	commit2=$(git rev-list -1 HEAD) &&
 	test_commit three foo.txt &&
-	commit3=`git rev-list -1 HEAD`
+	commit3=$(git rev-list -1 HEAD)
 	'
 
 test_expect_success '--parents rewrites TREESAME parents correctly' '
-- 
2.3.3.GIT

  parent reply	other threads:[~2016-01-07 13:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 13:51 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2016-01-07 13:51 ` [PATCH 01/10] t/t5900-repo-selection.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 02/10] t/t6001-rev-list-graft.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 03/10] t/t6002-rev-list-bisect.sh: " Elia Pinto
2016-01-07 13:51 ` Elia Pinto [this message]
2016-01-07 13:51 ` [PATCH 05/10] t/t6032-merge-large-rename.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 06/10] t/t6132-pathspec-exclude.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 07/10] t/t7001-mv.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 08/10] t/t7003-filter-branch.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 09/10] t/t7004-tag.sh: " Elia Pinto
2016-01-07 13:51 ` [PATCH 10/10] t/t7006-pager.sh: " Elia Pinto
2016-01-07 22:00 ` [PATCH 00/10] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452174710-28188-5-git-send-email-gitter.spiros@gmail.com \
    --to=gitter.spiros@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).