git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 03/10] t/t5532-fetch-proxy.sh: use the $( ... ) construct for command substitution
Date: Mon,  4 Jan 2016 10:10:44 +0100	[thread overview]
Message-ID: <1451898651-16468-4-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com>

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/t5532-fetch-proxy.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t5532-fetch-proxy.sh b/t/t5532-fetch-proxy.sh
index 5531bd1..d75ef0e 100755
--- a/t/t5532-fetch-proxy.sh
+++ b/t/t5532-fetch-proxy.sh
@@ -15,7 +15,7 @@ test_expect_success 'setup remote repo' '
 cat >proxy <<'EOF'
 #!/bin/sh
 echo >&2 "proxying for $*"
-cmd=`"$PERL_PATH" -e '
+cmd=$("$PERL_PATH" -e '
 	read(STDIN, $buf, 4);
 	my $n = hex($buf) - 4;
 	read(STDIN, $buf, $n);
@@ -23,7 +23,7 @@ cmd=`"$PERL_PATH" -e '
 	# drop absolute-path on repo name
 	$cmd =~ s{ /}{ };
 	print $cmd;
-'`
+')
 echo >&2 "Running '$cmd'"
 exec $cmd
 EOF
-- 
2.3.3.GIT

  parent reply	other threads:[~2016-01-04  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04  9:10 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2016-01-04  9:10 ` [PATCH 01/10] t/t5522-pull-symlink.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 02/10] t/t5530-upload-pack-error.sh: " Elia Pinto
2016-01-04  9:10 ` Elia Pinto [this message]
2016-01-04  9:10 ` [PATCH 04/10] t/t5537-fetch-shallow.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 05/10] t/t5538-push-shallow.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 06/10] t/t5550-http-fetch-dumb.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 07/10] t/t5570-git-daemon.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 08/10] t/t5601-clone.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 09/10] t/t5700-clone-reference.sh: " Elia Pinto
2016-01-04  9:10 ` [PATCH 10/10] t/t5710-info-alternate.sh: " Elia Pinto
2016-01-04 21:58 ` [PATCH 00/10] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451898651-16468-4-git-send-email-gitter.spiros@gmail.com \
    --to=gitter.spiros@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).