From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 03/10] t3403-rebase-skip.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 16:27:46 +0100 Message-ID: <1450798073-22811-4-git-send-email-gitter.spiros@gmail.com> References: <1450798073-22811-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 16:28:54 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBOrq-000305-Q2 for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 16:28:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932723AbbLVP2r (ORCPT ); Tue, 22 Dec 2015 10:28:47 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34975 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189AbbLVP2C (ORCPT ); Tue, 22 Dec 2015 10:28:02 -0500 Received: by mail-pf0-f179.google.com with SMTP id 78so35228132pfw.2 for ; Tue, 22 Dec 2015 07:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GiB+fiQtVl7pYe5hHQE7fybbzNtRD9+6eIi0oh2uoKs=; b=UqEQpwqKBW79qWSHMT/epVbpw8Y8kI0+WMG6Ccmm6q/rkj5pUYKSRcU3Cppebb0l2c Oyqof9EI5lkq1NfDhSVsGJnkw/jGfF0eiwuiPr2+SQjhL6QOXgCbe3ac9r3R5yCQUbQz OTBzz2S8e9aVTw4ZTxjG0qD5IMpAxH/95O8+tDhbMYXLqbd++PVQwBIAd8P1gksifNzK IhWC6EqT2/gurs13mfYWctOiRJYoBvWBDcihdZwSqJWp680aDMjOPF3jElv8C9j4kukL wCE9B+xb5jmcH8kg5Doy7YWdKehke9apviowUJ32ez0d4rwd8mUL+/B77saYA3jc2xp+ IyXQ== X-Received: by 10.98.31.153 with SMTP id l25mr11681574pfj.144.1450798081714; Tue, 22 Dec 2015 07:28:01 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id q190sm42030149pfq.59.2015.12.22.07.28.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 07:28:01 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450798073-22811-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t3403-rebase-skip.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3403-rebase-skip.sh b/t/t3403-rebase-skip.sh index 3968020..1f5122b 100755 --- a/t/t3403-rebase-skip.sh +++ b/t/t3403-rebase-skip.sh @@ -67,7 +67,7 @@ test_expect_success 'rebase --skip with --merge' ' ' test_expect_success 'merge and reference trees equal' ' - test -z "`git diff-tree skip-merge skip-reference`" + test -z "$(git diff-tree skip-merge skip-reference)" ' test_expect_success 'moved back to branch correctly' ' -- 2.3.3.GIT