From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 01/10] t3101-ls-tree-dirname.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 16:27:44 +0100 Message-ID: <1450798073-22811-2-git-send-email-gitter.spiros@gmail.com> References: <1450798073-22811-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 16:28:52 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBOrq-000305-45 for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 16:28:50 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755194AbbLVP2C (ORCPT ); Tue, 22 Dec 2015 10:28:02 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35382 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180AbbLVP2A (ORCPT ); Tue, 22 Dec 2015 10:28:00 -0500 Received: by mail-pa0-f47.google.com with SMTP id jx14so91027502pad.2 for ; Tue, 22 Dec 2015 07:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TGeqhYwiOIlhRGEHWEABggmGn6Y1AupVO6zF+tGR8v8=; b=JQLS7MCXFStkAmOra9+/947j3gXFchlMjeKLN+pC/GmH/YQBtFjLWRBga9b0g8sUFA sduVDyZZedWNt+dr3eXSmZKRsLRcrTRXEC57afozO2gn17YalmQEGVE7Fwew3+lHvPY+ xNTkr3iHufQz9UpAte/EpNskffRyUowiR5CJLFhj4haiaGPigSDh337V+MQ3ah9wUiEO SKIWGwmxmm0fQUZ3ByRA7JtnbWCtlH7qvCwiTjxRiSp+ccC8yvwlnYN4oq/WC9YOLxUc xxm9YKLqU/dWw96zTApX6/o4fLYJ4rs7GHRD5mj0Xu0mpuBA6wzCoTi01zuUvcwqw15b SB0Q== X-Received: by 10.66.140.39 with SMTP id rd7mr36326009pab.86.1450798079700; Tue, 22 Dec 2015 07:27:59 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id q190sm42030149pfq.59.2015.12.22.07.27.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 07:27:59 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450798073-22811-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t3101-ls-tree-dirname.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3101-ls-tree-dirname.sh b/t/t3101-ls-tree-dirname.sh index 026f9f8..425d858 100755 --- a/t/t3101-ls-tree-dirname.sh +++ b/t/t3101-ls-tree-dirname.sh @@ -35,7 +35,7 @@ test_expect_success 'setup' ' echo 222 >path3/2.txt && find *.txt path* \( -type f -o -type l \) -print | xargs git update-index --add && - tree=`git write-tree` && + tree=$(git write-tree) && echo $tree ' -- 2.3.3.GIT