From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 08/10] t/t2102-update-index-symlinks.sh: use the $( ... ) construct for command substitution
Date: Tue, 22 Dec 2015 16:05:53 +0100 [thread overview]
Message-ID: <1450796755-15848-9-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1450796755-15848-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
t/t2102-update-index-symlinks.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t2102-update-index-symlinks.sh b/t/t2102-update-index-symlinks.sh
index 4d0d0a3..22f2c73 100755
--- a/t/t2102-update-index-symlinks.sh
+++ b/t/t2102-update-index-symlinks.sh
@@ -23,7 +23,7 @@ git update-index symlink'
test_expect_success \
'the index entry must still be a symbolic link' '
-case "`git ls-files --stage --cached symlink`" in
+case "$(git ls-files --stage --cached symlink)" in
120000" "*symlink) echo pass;;
*) echo fail; git ls-files --stage --cached symlink; (exit 1);;
esac'
--
2.3.3.GIT
next prev parent reply other threads:[~2015-12-22 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 15:05 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2015-12-22 15:05 ` [PATCH 01/10] t/t1100-commit-tree-options.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 02/10] t/t1401-symbolic-ref.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 03/10] t/t1410-reflog.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 04/10] t/t1511-rev-parse-caret.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 05/10] t/t1512-rev-parse-disambiguation.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 06/10] t/t1700-split-index.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 07/10] t/t2025-worktree-add.sh: " Elia Pinto
2015-12-22 15:05 ` Elia Pinto [this message]
2015-12-22 15:05 ` [PATCH 09/10] t/t3030-merge-recursive.sh: " Elia Pinto
2015-12-22 15:05 ` [PATCH 10/10] t/t3100-ls-tree-restrict.sh: " Elia Pinto
2015-12-22 21:33 ` [PATCH 00/10] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450796755-15848-9-git-send-email-gitter.spiros@gmail.com \
--to=gitter.spiros@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).