From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 05/10] t/t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 16:05:50 +0100 Message-ID: <1450796755-15848-6-git-send-email-gitter.spiros@gmail.com> References: <1450796755-15848-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 16:06:44 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBOWN-0004s7-5H for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 16:06:39 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932972AbbLVPGa (ORCPT ); Tue, 22 Dec 2015 10:06:30 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34057 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932524AbbLVPGE (ORCPT ); Tue, 22 Dec 2015 10:06:04 -0500 Received: by mail-pa0-f53.google.com with SMTP id uo6so13614122pac.1 for ; Tue, 22 Dec 2015 07:06:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2JbbSmzlEJsySoiEDAVi9+un3uZNM25jJsWdpKBpi0I=; b=CHF0KcDCvP5DVvHjtFeec/85O8nRogoRo5nyXXWuCv7q+q9U9ezngbhk6lxmlw/OGV AAMWxZ065jEFY8rnql5pSDMhwdpxIpunorUzqoMUEyMiRTz7JNWBvUcDAp5NceHU+i5r vo1q7IRCUN6tfdZ1tMOq1i9t/R82K+7oh84JuoxxZ4Yur3svX0EPmPY6lt5o/xo8D6Pz dKfIchRKvrYdBS7Iua5/QeIAStogKkeIzX0IEhWH1yffZzEdydRiCWJ7z84cU7lDQeRD XrB2q3y6PGBmoHBEXe997iUwuFR93SEIG89mwFNQ+Pe2qPsLIxhLFeeKdHKNjLKu9zqH KVRA== X-Received: by 10.66.216.200 with SMTP id os8mr36519882pac.143.1450796763660; Tue, 22 Dec 2015 07:06:03 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id hz8sm46766591pac.10.2015.12.22.07.06.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 07:06:03 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450796755-15848-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t1512-rev-parse-disambiguation.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-disambiguation.sh index 4a155c8..e221167 100755 --- a/t/t1512-rev-parse-disambiguation.sh +++ b/t/t1512-rev-parse-disambiguation.sh @@ -275,19 +275,19 @@ test_expect_success 'rev-parse --disambiguate' ' test_expect_success 'ambiguous 40-hex ref' ' TREE=$(git mktree err` = $REF && + test $(git rev-parse $REF 2>err) = $REF && grep "refname.*${REF}.*ambiguous" err ' test_expect_success 'ambiguous short sha1 ref' ' TREE=$(git mktree err` = $VAL && + test $(git rev-parse $REF 2>err) = $VAL && grep "refname.*${REF}.*ambiguous" err ' -- 2.3.3.GIT