From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 02/10] t/t1401-symbolic-ref.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 16:05:47 +0100 Message-ID: <1450796755-15848-3-git-send-email-gitter.spiros@gmail.com> References: <1450796755-15848-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 16:06:13 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBOVv-00049p-Lg for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 16:06:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932557AbbLVPGF (ORCPT ); Tue, 22 Dec 2015 10:06:05 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35278 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbbLVPGB (ORCPT ); Tue, 22 Dec 2015 10:06:01 -0500 Received: by mail-pa0-f48.google.com with SMTP id jx14so90777965pad.2 for ; Tue, 22 Dec 2015 07:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qbk9w/dgV4WIYqf02zH3ZBDZKvmPzMhdjVkbXrfF8DE=; b=1JvPYIiqhIeIeV0y6hK42FDc27krBSho99ZnThnbMVKj6Bdmy8QHcnPWyN3brWqRNG 2ryoVKy5C+p1ahsLRY/iS9uo7VIKZq4AQLkfRhgjhrKQS5A99OnryB/Dkt/clwVHOjlN 2nfRJJIMH5/3sgB7HRiaKOl8pZiLVwYiyVAXuYeR4Nihy5q1wJAvTvJV4d9bEOJ31egg aKR60Raaqk1CpfoXLUPdDmTFvWDUgtsLQLGYgICOM4SM6wuGjZW7M+n+LHzcTSmSKFnl IUidpu6DbdoweG1imZOXdOA4uXACBWFybSuMOyURZO4WXDrzij3sCygHMP71647sfjlg oMLA== X-Received: by 10.66.62.166 with SMTP id z6mr36255401par.122.1450796760834; Tue, 22 Dec 2015 07:06:00 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id hz8sm46766591pac.10.2015.12.22.07.05.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 07:06:00 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450796755-15848-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t1401-symbolic-ref.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh index 20b022a..e6c5830 100755 --- a/t/t1401-symbolic-ref.sh +++ b/t/t1401-symbolic-ref.sh @@ -29,7 +29,7 @@ reset_to_sane test_expect_success 'symbolic-ref refuses bare sha1' ' echo content >file && git add file && git commit -m one && - test_must_fail git symbolic-ref HEAD `git rev-parse HEAD` + test_must_fail git symbolic-ref HEAD $(git rev-parse HEAD) ' reset_to_sane -- 2.3.3.GIT