From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 07/10] git-gui/po/glossary/txt-to-pot.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 15:10:29 +0100 Message-ID: <1450793432-9345-8-git-send-email-gitter.spiros@gmail.com> References: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 15:11:14 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBNej-000389-Ub for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 15:11:14 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754297AbbLVOLG (ORCPT ); Tue, 22 Dec 2015 09:11:06 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34535 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbbLVOKq (ORCPT ); Tue, 22 Dec 2015 09:10:46 -0500 Received: by mail-pa0-f48.google.com with SMTP id uo6so13016368pac.1 for ; Tue, 22 Dec 2015 06:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F42Q1r60aVCU+OQb8EGTtgWvZ4baHBO1YiUq1HiNcXM=; b=rV03/waTKuSZQKEVIfThCod0tV3JKOKjA+aCCABF7UVAFFga/wxmqbrJXUvJDtaLVG 8oKl6vu9wJ0mFnbAa2kTJJTaVNpMBe2Z3PXC3pyM4Vg3mQmCJN/StiHxcKpPHQC3qYNf VMVIOsSk53WlrGdRGdcFICplW6xuXAyWKXAEGMMEGJr2ec4hFdqZAa8jdw57zbwsyE4Y Ue1q2guSylxaXD9+5n8llqQ0+vcD3eZ3CjzTr9Drdfr9Yok8OfTGFgxUB8uEns9AFvDZ lr0Aw2R3sM6VRWOexs4ycxXU1IJM+xMJStws7MNZOWCfbU/dlCoR58+gTSxO/E2FJsyr aeDQ== X-Received: by 10.67.7.101 with SMTP id db5mr35570455pad.53.1450793446419; Tue, 22 Dec 2015 06:10:46 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id fe6sm46421455pab.40.2015.12.22.06.10.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 06:10:45 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- git-gui/po/glossary/txt-to-pot.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-gui/po/glossary/txt-to-pot.sh b/git-gui/po/glossary/txt-to-pot.sh index 49bf7c5..8249915 100755 --- a/git-gui/po/glossary/txt-to-pot.sh +++ b/git-gui/po/glossary/txt-to-pot.sh @@ -11,7 +11,7 @@ if [ $# -eq 0 ] then cat < git-gui-glossary.pot +Usage: $(basename $0) git-gui-glossary.txt > git-gui-glossary.pot ! exit 1; fi @@ -33,7 +33,7 @@ cat <\n" "Language-Team: LANGUAGE \n" -- 2.3.3.GIT