From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 06/10] contrib/thunderbird-patch-inline/appp.sh: use the $( ... ) construct for command substitution
Date: Tue, 22 Dec 2015 15:10:28 +0100 [thread overview]
Message-ID: <1450793432-9345-7-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
contrib/thunderbird-patch-inline/appp.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/thunderbird-patch-inline/appp.sh b/contrib/thunderbird-patch-inline/appp.sh
index 8dc73ec..1053872 100755
--- a/contrib/thunderbird-patch-inline/appp.sh
+++ b/contrib/thunderbird-patch-inline/appp.sh
@@ -31,8 +31,8 @@ BODY=$(sed -e "1,/${SEP}/d" $1)
CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' "${PATCH}")
DIFF=$(sed -e '1,/^---$/d' "${PATCH}")
-CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
- -e 's/^Signed-off-by: \(.*\)/\1,/gp'`
+CCS=$(echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
+ -e 's/^Signed-off-by: \(.*\)/\1,/gp')
echo "$SUBJECT" > $1
echo "Cc: $CCS" >> $1
--
2.3.3.GIT
next prev parent reply other threads:[~2015-12-22 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 14:10 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2015-12-22 14:10 ` [PATCH 01/10] contrib/examples/git-commit.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 02/10] contrib/examples/git-fetch.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 03/10] contrib/examples/git-merge.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 04/10] contrib/examples/git-repack.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 05/10] contrib/examples/git-revert.sh: " Elia Pinto
2015-12-22 14:10 ` Elia Pinto [this message]
2015-12-22 14:10 ` [PATCH 07/10] git-gui/po/glossary/txt-to-pot.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 08/10] t/lib-httpd.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 09/10] test-sha1.sh: " Elia Pinto
2015-12-22 14:10 ` [PATCH 10/10] unimplemented.sh: " Elia Pinto
2015-12-22 20:45 ` [PATCH 00/10] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450793432-9345-7-git-send-email-gitter.spiros@gmail.com \
--to=gitter.spiros@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).