From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 02/10] contrib/examples/git-fetch.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 15:10:24 +0100 Message-ID: <1450793432-9345-3-git-send-email-gitter.spiros@gmail.com> References: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 15:10:53 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBNeO-0002Wb-6a for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 15:10:52 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754161AbbLVOKt (ORCPT ); Tue, 22 Dec 2015 09:10:49 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33049 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754059AbbLVOKm (ORCPT ); Tue, 22 Dec 2015 09:10:42 -0500 Received: by mail-pa0-f45.google.com with SMTP id cy9so35653253pac.0 for ; Tue, 22 Dec 2015 06:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7/LjkZZiQVQEqmVa8yi0xXX7mjZERwr+9Kt40RI8eeY=; b=Lgx6muWxJ7PnsUSprLgEz+Zc9V9Z0ZvmplH0HkfOD/LHL/F4nr7KNupk+ipITA7bS4 OItPLke2ZnL2v+iU4KoBjvSfPt2hxgS7szOK04Qc3o/R4bJjItoUiBDwWfIoMivoM0lX 3YWhZ32ErfEx2cYfJvenbcekLoeXoHFDAJOrXnPJLtMT5kU3ESKmBWSVfJ8bPHFssaSA 9c6Um+gT2rghx2x9Latotw6XfNOVOJwtA+wLlPzAfcio6Zk18j+Meq5TMZ1Pa7wU4l9g 066SbBFnddSFq6MLb8vVh32YVDBb1favXsvjBnPmpNKd9Z4LMFvKgasHQ+LYRWmYc3AF ntoQ== X-Received: by 10.66.248.74 with SMTP id yk10mr35480848pac.17.1450793441933; Tue, 22 Dec 2015 06:10:41 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id fe6sm46421455pab.40.2015.12.22.06.10.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 06:10:41 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- contrib/examples/git-fetch.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/examples/git-fetch.sh b/contrib/examples/git-fetch.sh index 5540709..57d2e56 100755 --- a/contrib/examples/git-fetch.sh +++ b/contrib/examples/git-fetch.sh @@ -146,13 +146,13 @@ esac reflist=$(get_remote_refs_for_fetch "$@") if test "$tags" then - taglist=`IFS=' ' && + taglist=$(IFS=' ' && echo "$ls_remote_result" | git show-ref --exclude-existing=refs/tags/ | while read sha1 name do echo ".${name}:${name}" - done` || exit + done) || exit if test "$#" -gt 1 then # remote URL plus explicit refspecs; we need to merge them. -- 2.3.3.GIT