From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH 10/10] unimplemented.sh: use the $( ... ) construct for command substitution Date: Tue, 22 Dec 2015 15:10:32 +0100 Message-ID: <1450793432-9345-11-git-send-email-gitter.spiros@gmail.com> References: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com> Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Dec 22 15:10:58 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBNeT-0002jz-LH for gcvg-git-2@plane.gmane.org; Tue, 22 Dec 2015 15:10:58 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754216AbbLVOKv (ORCPT ); Tue, 22 Dec 2015 09:10:51 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33095 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155AbbLVOKt (ORCPT ); Tue, 22 Dec 2015 09:10:49 -0500 Received: by mail-pa0-f45.google.com with SMTP id cy9so35654552pac.0 for ; Tue, 22 Dec 2015 06:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YPQbB0fbAh6OR/zTKGLt14NWzuQAj8Qm7Q6cqABXTBM=; b=jMQ+/iLLImQvNM5mQYQeOlHx/YCAW3SQ6QqgEbexVIG1OfOyIYHDTj5miSJRELL+7m FMGWAl6ezU0YFwBvc99Tcy/uNcZ7HPMMpgu2fw36Z7FE92mzzkj7v4qZ9F1wHgxA7b9E OAv8glnO4XOTbZUVah1ZiUoBbsolVN8QVA34kTTiSKhUzSHucXZCetsDRdkCgE6p0mbR 5ljLPBWLugVJ+R26mXsjFLeIhGVN/lhXN4pe8ymOpjI3RLqYKnvMUXJSutfmWIHBIYOc qnVGFfAF/YGILGj9ts2X37AAl5MPQHHgiQmx/R9ucNdtCLDB1xyrIG/ey2YuKmW3qZMs 206Q== X-Received: by 10.66.160.229 with SMTP id xn5mr35963617pab.0.1450793448976; Tue, 22 Dec 2015 06:10:48 -0800 (PST) Received: from ubuntu14.nephoscale.com (static-67.207.195.141.nephosdns.com. [67.207.195.141]) by smtp.gmail.com with ESMTPSA id fe6sm46421455pab.40.2015.12.22.06.10.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Dec 2015 06:10:48 -0800 (PST) X-Mailer: git-send-email 2.3.3.GIT In-Reply-To: <1450793432-9345-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- unimplemented.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unimplemented.sh b/unimplemented.sh index 5252de4..fee21d2 100644 --- a/unimplemented.sh +++ b/unimplemented.sh @@ -1,4 +1,4 @@ #!/bin/sh -echo >&2 "fatal: git was built without support for `basename $0` (@@REASON@@)." +echo >&2 "fatal: git was built without support for $(basename $0) (@@REASON@@)." exit 128 -- 2.3.3.GIT