From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "sunshine@sunshineco.com" <sunshine@sunshineco.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"gitster@pobox.com" <gitster@pobox.com>,
"spearce@spearce.org" <spearce@spearce.org>,
"felipe.contreras@gmail.com" <felipe.contreras@gmail.com>,
"szeder@ira.uka.de" <szeder@ira.uka.de>,
"jacob.keller@gmail.com" <jacob.keller@gmail.com>,
"lee.marlow@gmail.com" <lee.marlow@gmail.com>
Subject: Re: [PATCH v2 1/2] sendemail: teach git-send-email to list aliases
Date: Mon, 16 Nov 2015 23:40:27 +0000 [thread overview]
Message-ID: <1447717227.23262.10.camel@intel.com> (raw)
In-Reply-To: <CAPig+cQ929oAZqQM+X68x3PVQ-opwdi3VzjcQTUsaCfVK3411g@mail.gmail.com>
On Mon, 2015-11-16 at 18:30 -0500, Eric Sunshine wrote:
> On Sun, Nov 15, 2015 at 3:22 PM, Jacob Keller <jacob.e.keller@intel.c
> om> wrote:
> > Add an option "list-aliases" which changes the default behavior of
> > git-send-email. This mode will simply read the alias files
> > configured by
> > sendemail.aliasesfile and sendemail.aliasfiletype and print a list
> > of
> > all known aliases. The intended usecase for this option is the
> > bash-completion script which will use it to autocomplete aliases on
> > the
> > options which take addresses.
>
> As this is primarily a plumbing option, I wonder if --dump-aliases
> might be a more suitable name.
>
Sure that would be reasonable.
> Also, is it possible that some consumer down the road might want
> richer output which includes the expansion of each alias? For
> instance, it could emit the alias name as the first token on each
> line
> and the expansion as the remainder. Consumers interested in only the
> alias name would grab the first token on the line and ignore
> everything else.
>
Maybe? The problem with printing the full address is that it may not be
quoted or similar, and it makes the bash completion require an extra
parameter.. I am not sure how valuable the alias expansion would be for
use? The main concern I have is we'd need to use another process on top
to extract only alias names.
> > Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
> > ---
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > @@ -101,6 +102,9 @@ git send-email [options] <file | directory |
> > rev-list options >
> > `git format-patch` ones.
> > --force * Send even if safety checks
> > would prevent it.
> >
> > + Information:
> > + --list-aliases * read the aliases from
> > configured alias files
>
> This description is odd. It seems to imply that aliases will be
> loaded
> (and used) only if this option is given, and says nothing about its
> actual purpose of dumping the aliases.
>
I can re-word this.
> Also, with one exception, all the other option descriptions are
> capitalized. This probably ought to follow suit.
>
> > +if ($list_aliases) {
> > + print $_,"\n" for (keys %aliases);
> > + exit(0);
> > +}
>
> New test(s) seem to be missing.
>
I had removed the tests from the old version because they weren't
necessary anymore. New ones wouldn't hurt here either, though.. I'll
work on that.
Regards,
Jake
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-16 23:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 20:22 [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Jacob Keller
2015-11-15 20:22 ` [PATCH v2 2/2] completion: add support for completing email aliases Jacob Keller
2015-11-16 23:33 ` Eric Sunshine
2015-11-16 23:40 ` Keller, Jacob E
2015-11-16 23:30 ` [PATCH v2 1/2] sendemail: teach git-send-email to list aliases Eric Sunshine
2015-11-16 23:40 ` Keller, Jacob E [this message]
2015-11-16 23:50 ` Eric Sunshine
2015-11-16 23:56 ` Eric Sunshine
2015-11-17 0:09 ` Keller, Jacob E
2015-11-17 0:10 ` Keller, Jacob E
2015-11-17 7:20 ` Eric Sunshine
2015-11-17 8:25 ` Jacob Keller
2015-11-17 12:26 ` SZEDER Gábor
2015-11-17 16:27 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447717227.23262.10.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=lee.marlow@gmail.com \
--cc=spearce@spearce.org \
--cc=sunshine@sunshineco.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).