From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Beller Subject: [PATCHv4 4/9] submodule-config: remove name_and_item_from_var Date: Fri, 13 Nov 2015 17:06:57 -0800 Message-ID: <1447463222-12589-5-git-send-email-sbeller@google.com> References: <1447463222-12589-1-git-send-email-sbeller@google.com> Cc: ramsay@ramsayjones.plus.com, jacob.keller@gmail.com, peff@peff.net, gitster@pobox.com, jrnieder@gmail.com, johannes.schindelin@gmail.com, Jens.Lehmann@web.de, ericsunshine@gmail.com, j6t@kdbg.org, Stefan Beller To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Nov 14 02:07:50 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZxPJj-0003nQ-Kp for gcvg-git-2@plane.gmane.org; Sat, 14 Nov 2015 02:07:47 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbbKNBHn (ORCPT ); Fri, 13 Nov 2015 20:07:43 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33427 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbbKNBHT (ORCPT ); Fri, 13 Nov 2015 20:07:19 -0500 Received: by pabfh17 with SMTP id fh17so115998134pab.0 for ; Fri, 13 Nov 2015 17:07:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6mlUMeUd1nsdWYCDSESKOM8zaU/K3lyMP+sQR9SBrBY=; b=bXyydm01bHFuy1OOygNZGnKAwNIunnJy/R5A6ULccln7P95Lh9TlanPTa8F39BHYgR tyETYrWfLMaIHIgoBb8/GDEIs3e9VXHsxBJxquf6LyyhNWzjt2c/uMLWaRe0uEz+9TPd GUlCWN3Y0wjNQQ/5ogxR9DZzmKf4vZ59CCfZ6d4Yuh2l1r+k+3K4Rcw8NAoZpfjOqnVo uuC7d76+1dYTEfW7BzY//fD1WnV4mfIG3ADHNxkjAb9TgfQSEcrh+sIZMtpTuIvU8gc2 7JP3iFfnw+GaOB5UGE4OkLI4azZheRLjOpO4DAVjUx1X5ar7ujB3nxt2yNlJ2FT0rbq7 8Vlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6mlUMeUd1nsdWYCDSESKOM8zaU/K3lyMP+sQR9SBrBY=; b=a/9mzG5MmzIHb2a7M6/b1uJKJEH3v8EIBGL8FXZrPDbphcuCsM8qoEk4ru/UK1nnJH lECmaK18pKXkHCFoRIFD9vLTRLFZx6kDqnVvhirRA2KKJfTg8Kr2jP8U+0fphLEucaW/ aV+XFjoCwnZ2vaHO5p/xxOIFCqADM0/0mYVuoC5YtrxXi2vczZMc1N8il39afLb7JZWl b3UtD2xN7d15CONC2kMrND5nvDW3jOJI+DpE5DtrBuNUfRaV5zGWmBDR13Y6STij/Gvm h0RO5mTI3Wmnmvr9itChqtbQu5ZRXgDKX/aqvqZhj/fs5dayK43jTRn2wZN+KO2a39ku TAKA== X-Gm-Message-State: ALoCoQnDH8dZ+WHWlBEJaOxgXz0yhXwM68/oOBVBBgCDlXU4IKErdvPDili5kcq2MjrqBJ0gM0UZ X-Received: by 10.68.109.196 with SMTP id hu4mr36372567pbb.71.1447463238533; Fri, 13 Nov 2015 17:07:18 -0800 (PST) Received: from localhost ([2620:0:1000:5b00:f5eb:b7b9:3afa:a95c]) by smtp.gmail.com with ESMTPSA id mt2sm18152209pbb.90.2015.11.13.17.07.17 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 13 Nov 2015 17:07:18 -0800 (PST) X-Mailer: git-send-email 2.6.3.369.gea52ac0 In-Reply-To: <1447463222-12589-1-git-send-email-sbeller@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: `name_and_item_from_var` does not provide the proper abstraction we need here in a later patch. Signed-off-by: Stefan Beller --- submodule-config.c | 48 ++++++++++++++++-------------------------------- 1 file changed, 16 insertions(+), 32 deletions(-) diff --git a/submodule-config.c b/submodule-config.c index 6d01941..b826841 100644 --- a/submodule-config.c +++ b/submodule-config.c @@ -161,31 +161,17 @@ static struct submodule *cache_lookup_name(struct submodule_cache *cache, return NULL; } -static int name_and_item_from_var(const char *var, struct strbuf *name, - struct strbuf *item) -{ - const char *subsection, *key; - int subsection_len, parse; - parse = parse_config_key(var, "submodule", &subsection, - &subsection_len, &key); - if (parse < 0 || !subsection) - return 0; - - strbuf_add(name, subsection, subsection_len); - strbuf_addstr(item, key); - - return 1; -} - static struct submodule *lookup_or_create_by_name(struct submodule_cache *cache, - const unsigned char *gitmodules_sha1, const char *name) + const unsigned char *gitmodules_sha1, + const char *name_ptr, int name_len) { struct submodule *submodule; struct strbuf name_buf = STRBUF_INIT; + char *name = xmemdupz(name_ptr, name_len); submodule = cache_lookup_name(cache, gitmodules_sha1, name); if (submodule) - return submodule; + goto out; submodule = xmalloc(sizeof(*submodule)); @@ -201,7 +187,8 @@ static struct submodule *lookup_or_create_by_name(struct submodule_cache *cache, hashcpy(submodule->gitmodules_sha1, gitmodules_sha1); cache_add(cache, submodule); - +out: + free(name); return submodule; } @@ -251,18 +238,18 @@ static int parse_config(const char *var, const char *value, void *data) { struct parse_config_parameter *me = data; struct submodule *submodule; - struct strbuf name = STRBUF_INIT, item = STRBUF_INIT; - int ret = 0; + int subsection_len, ret = 0; + const char *subsection, *key; - /* this also ensures that we only parse submodule entries */ - if (!name_and_item_from_var(var, &name, &item)) + if (parse_config_key(var, "submodule", &subsection, + &subsection_len, &key) < 0 || !subsection_len) return 0; submodule = lookup_or_create_by_name(me->cache, me->gitmodules_sha1, - name.buf); + subsection, subsection_len); - if (!strcmp(item.buf, "path")) { + if (!strcmp(key, "path")) { if (!value) ret = config_error_nonbool(var); else if (!me->overwrite && submodule->path) @@ -275,7 +262,7 @@ static int parse_config(const char *var, const char *value, void *data) submodule->path = xstrdup(value); cache_put_path(me->cache, submodule); } - } else if (!strcmp(item.buf, "fetchrecursesubmodules")) { + } else if (!strcmp(key, "fetchrecursesubmodules")) { /* when parsing worktree configurations we can die early */ int die_on_error = is_null_sha1(me->gitmodules_sha1); if (!me->overwrite && @@ -286,7 +273,7 @@ static int parse_config(const char *var, const char *value, void *data) submodule->fetch_recurse = parse_fetch_recurse( var, value, die_on_error); - } else if (!strcmp(item.buf, "ignore")) { + } else if (!strcmp(key, "ignore")) { if (!value) ret = config_error_nonbool(var); else if (!me->overwrite && submodule->ignore) @@ -302,7 +289,7 @@ static int parse_config(const char *var, const char *value, void *data) free((void *) submodule->ignore); submodule->ignore = xstrdup(value); } - } else if (!strcmp(item.buf, "url")) { + } else if (!strcmp(key, "url")) { if (!value) { ret = config_error_nonbool(var); } else if (!me->overwrite && submodule->url) { @@ -312,7 +299,7 @@ static int parse_config(const char *var, const char *value, void *data) free((void *) submodule->url); submodule->url = xstrdup(value); } - } else if (!strcmp(item.buf, "update")) { + } else if (!strcmp(key, "update")) { if (!value) ret = config_error_nonbool(var); else if (!me->overwrite && submodule->update) @@ -324,9 +311,6 @@ static int parse_config(const char *var, const char *value, void *data) } } - strbuf_release(&name); - strbuf_release(&item); - return ret; } -- 2.6.3.369.gea52ac0