From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: git@vger.kernel.org
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
sunshine@sunshineco.com, paulus@samba.org
Subject: [PATCH v3] gitk: add -C <path> commandline parameter to change path
Date: Mon, 9 Nov 2015 13:45:22 +0200 [thread overview]
Message-ID: <1447069522-19895-1-git-send-email-juhapekka.heikkila@gmail.com> (raw)
In-Reply-To: <563C85C5.80703@gmail.com>
This patch adds -C (change working directory) parameter to
gitk. With this parameter, instead of need to cd to directory
with .git folder, one can point the correct folder from
commandline.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
v2: Adjusted the parameter as per Eric's suggestion. I think
it now work in similar manner as in many GNU tools as well
as git itself.
v3: catch error from cd and other small refinement.
Documentation/gitk.txt | 7 +++++++
gitk-git/gitk | 30 +++++++++++++++++++++---------
2 files changed, 28 insertions(+), 9 deletions(-)
diff --git a/Documentation/gitk.txt b/Documentation/gitk.txt
index 6ade002..d194d9b 100644
--- a/Documentation/gitk.txt
+++ b/Documentation/gitk.txt
@@ -146,6 +146,13 @@ gitk-specific options
Select the specified commit after loading the graph.
Default behavior is equivalent to specifying '--select-commit=HEAD'.
+-C <path>::
+
+ Run as if gitk was started in '<path>' instead of the current
+ working directory. When multiple `-C` options are given, each
+ subsequent non-absolute `-C <path>` is interpreted relative to
+ the preceding `-C <path>`.
+
Examples
--------
gitk v2.6.12.. include/scsi drivers/scsi::
diff --git a/gitk-git/gitk b/gitk-git/gitk
index fcc606e..a7076f8 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -12279,20 +12279,14 @@ setui $uicolor
setoptions
-# check that we can find a .git directory somewhere...
-if {[catch {set gitdir [exec git rev-parse --git-dir]}]} {
- show_error {} . [mc "Cannot find a git repository here."]
- exit 1
-}
-
set selecthead {}
set selectheadid {}
set revtreeargs {}
set cmdline_files {}
-set i 0
set revtreeargscmd {}
-foreach arg $argv {
+for {set i 0} {$i < [llength $argv]} {incr i} {
+ set arg [lindex $argv [expr {$i}]]
switch -glob -- $arg {
"" { }
"--" {
@@ -12305,11 +12299,29 @@ foreach arg $argv {
"--argscmd=*" {
set revtreeargscmd [string range $arg 10 end]
}
+ "-C*" {
+ if {[string length $arg] < 3} {
+ incr i
+ set cwd_path [lindex $argv [expr {$i}]]
+ } else {
+ set cwd_path [string range $arg 2 end]
+ }
+
+ if {[catch {cd $cwd_path}]} {
+ show_error {} . [mc "Cannot change directory to '%s'" $cwd_path]
+ exit 1
+ }
+ }
default {
lappend revtreeargs $arg
}
}
- incr i
+}
+
+# check that we can find a .git directory somewhere...
+if {[catch {set gitdir [exec git rev-parse --git-dir]}]} {
+ show_error {} . [mc "Cannot find a git repository here."]
+ exit 1
}
if {$selecthead eq "HEAD"} {
--
1.9.1
next prev parent reply other threads:[~2015-11-09 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 15:00 [PATCH 0/1] gitk: add --cwd=path commandline parameter to change path Juha-Pekka Heikkila
2015-11-03 15:00 ` [PATCH 1/1] " Juha-Pekka Heikkila
2015-11-03 18:27 ` Eric Sunshine
2015-11-05 9:19 ` [PATCH v2] gitk: add -C <path> " Juha-Pekka Heikkila
2015-11-06 9:48 ` Eric Sunshine
2015-11-06 10:49 ` Juha-Pekka Heikkila
2015-11-09 11:45 ` Juha-Pekka Heikkila [this message]
2015-12-19 3:13 ` [PATCH v3] " Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447069522-19895-1-git-send-email-juhapekka.heikkila@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).