git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: ramsay@ramsayjones.plus.com, jacob.keller@gmail.com,
	peff@peff.net, gitster@pobox.com, jrnieder@gmail.com,
	johannes.schindelin@gmail.com, Jens.Lehmann@web.de,
	ericsunshine@gmail.com, Stefan Beller <sbeller@google.com>
Subject: [PATCH 3/8] run-command: Initialize the shutdown flag
Date: Tue, 20 Oct 2015 15:43:45 -0700	[thread overview]
Message-ID: <1445381030-23912-4-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1445381030-23912-1-git-send-email-sbeller@google.com>

It did work out without initializing the flag so far, but to make it
future proof, we want to explicitly initialize the flag.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 run-command.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/run-command.c b/run-command.c
index a5ef874..d354c01 100644
--- a/run-command.c
+++ b/run-command.c
@@ -962,6 +962,7 @@ static struct parallel_processes *pp_init(int n,
 
 	pp->nr_processes = 0;
 	pp->output_owner = 0;
+	pp->shutdown = 0;
 	pp->children = xcalloc(n, sizeof(*pp->children));
 	pp->pfd = xcalloc(n, sizeof(*pp->pfd));
 	strbuf_init(&pp->buffered_output, 0);
-- 
2.5.0.275.gbfc1651.dirty

  parent reply	other threads:[~2015-10-20 22:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 22:43 [PATCH 0/8] Fixes for the parallel processing engine and git submodule update Stefan Beller
2015-10-20 22:43 ` [PATCH 1/8] run-command: Fix early shutdown Stefan Beller
2015-10-20 22:43 ` [PATCH 2/8] run-command: Call get_next_task with a clean child process Stefan Beller
2015-10-20 23:05   ` Junio C Hamano
2015-10-20 23:05   ` Junio C Hamano
2015-10-21 20:30     ` Junio C Hamano
2015-10-21 21:07       ` Stefan Beller
2015-10-20 22:43 ` Stefan Beller [this message]
2015-10-20 22:43 ` [PATCH 4/8] test-run-command: Test for gracefully aborting Stefan Beller
2015-10-20 22:43 ` [PATCH 5/8] test-run-command: Increase test coverage Stefan Beller
2015-10-20 22:43 ` [PATCH 6/8] run-command: Fix missing output from late callbacks Stefan Beller
2015-10-20 22:43 ` [PATCH 7/8] submodule config: Keep update strategy around Stefan Beller
2015-10-20 22:43 ` [PATCH 8/8] git submodule update: Have a dedicated helper for cloning Stefan Beller
2015-10-21 20:47   ` Junio C Hamano
2015-10-21 21:06     ` Stefan Beller
2015-10-21 21:23       ` Junio C Hamano
2015-10-21 22:14         ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445381030-23912-4-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=Jens.Lehmann@web.de \
    --cc=ericsunshine@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacob.keller@gmail.com \
    --cc=johannes.schindelin@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).