git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: larsxschneider@gmail.com
To: git@vger.kernel.org
Cc: luke@diamand.org, Lars Schneider <larsxschneider@gmail.com>
Subject: [PATCH v8 5/7] git-p4: check free space during streaming
Date: Sat, 26 Sep 2015 09:55:02 +0200	[thread overview]
Message-ID: <1443254104-14966-6-git-send-email-larsxschneider@gmail.com> (raw)
In-Reply-To: <1443254104-14966-1-git-send-email-larsxschneider@gmail.com>

From: Lars Schneider <larsxschneider@gmail.com>

git-p4 will just halt if there is not enough disk space while
streaming content from P4 to Git. Add a check to ensure at least
4 times (arbitrarily chosen) the size of a streamed file is available.

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 git-p4.py | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/git-p4.py b/git-p4.py
index e7a7ea4..6b1e395 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -104,6 +104,16 @@ def chdir(path, is_client_path=False):
         path = os.getcwd()
     os.environ['PWD'] = path
 
+def calcDiskFree():
+    """Return free space in bytes on the disk of the given dirname."""
+    if platform.system() == 'Windows':
+        free_bytes = ctypes.c_ulonglong(0)
+        ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))
+        return free_bytes.value
+    else:
+        st = os.statvfs(os.getcwd())
+        return st.f_bavail * st.f_frsize
+
 def die(msg):
     if verbose:
         raise Exception(msg)
@@ -2256,6 +2266,14 @@ class P4Sync(Command, P4UserMap):
             if marshalled["code"] == "error":
                 if "data" in marshalled:
                     err = marshalled["data"].rstrip()
+
+        if not err and 'fileSize' in self.stream_file:
+            required_bytes = int((4 * int(self.stream_file["fileSize"])) - calcDiskFree())
+            if required_bytes > 0:
+                err = 'Not enough space left on %s! Free at least %i MB.' % (
+                    os.getcwd(), required_bytes/1024/1024
+                )
+
         if err:
             f = None
             if self.stream_have_file_info:
-- 
2.5.1

  parent reply	other threads:[~2015-09-26  7:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26  7:54 [PATCH v8 0/7] git-p4: add support for large file systems larsxschneider
2015-09-26  7:54 ` [PATCH v8 1/7] git-p4: add optional type specifier to gitConfig reader larsxschneider
2015-09-26  7:54 ` [PATCH v8 2/7] git-p4: add gitConfigInt reader larsxschneider
2015-09-26  7:55 ` [PATCH v8 3/7] git-p4: return an empty list if a list config has no values larsxschneider
2015-09-26  7:55 ` [PATCH v8 4/7] git-p4: add file streaming progress in verbose mode larsxschneider
2015-09-26  7:55 ` larsxschneider [this message]
2015-09-26  7:55 ` [PATCH v8 6/7] git-p4: add support for large file systems larsxschneider
2015-09-26  7:55 ` [PATCH v8 7/7] git-p4: add Git LFS backend for large file system larsxschneider
2015-09-28 19:55 ` [PATCH v8 0/7] git-p4: add support for large file systems Junio C Hamano
2015-10-03 16:27 ` Luke Diamand
2015-10-03 17:17   ` Junio C Hamano
2015-10-03 17:23     ` Junio C Hamano
2015-10-04 18:15       ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443254104-14966-6-git-send-email-larsxschneider@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).