git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr,
	gitster@pobox.com, Karthik Nayak <Karthik.188@gmail.com>,
	Karthik Nayak <karthik.188@gmail.com>
Subject: [PATCH v13 01/12] ref-filter: move `struct atom_value` to ref-filter.c
Date: Sat, 22 Aug 2015 09:09:37 +0530	[thread overview]
Message-ID: <1440214788-1309-2-git-send-email-Karthik.188@gmail.com> (raw)
In-Reply-To: <1440214788-1309-1-git-send-email-Karthik.188@gmail.com>

Since atom_value is only required for the internal working of
ref-filter it doesn't belong in the public header.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 ref-filter.c | 5 +++++
 ref-filter.h | 5 +----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/ref-filter.c b/ref-filter.c
index 46963a5..e53c77e 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -55,6 +55,11 @@ static struct {
 	{ "color" },
 };
 
+struct atom_value {
+	const char *s;
+	unsigned long ul; /* used for sorting when not FIELD_STR */
+};
+
 /*
  * An atom is a valid field atom listed above, possibly prefixed with
  * a "*" to denote deref_tag().
diff --git a/ref-filter.h b/ref-filter.h
index 6bf27d8..45026d0 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -16,10 +16,7 @@
 #define FILTER_REFS_INCLUDE_BROKEN 0x1
 #define FILTER_REFS_ALL 0x2
 
-struct atom_value {
-	const char *s;
-	unsigned long ul; /* used for sorting when not FIELD_STR */
-};
+struct atom_value;
 
 struct ref_sorting {
 	struct ref_sorting *next;
-- 
2.5.0

  reply	other threads:[~2015-08-22  3:39 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22  3:39 [PATCH v13 00/12] port tag.c to use ref-filter APIs Karthik Nayak
2015-08-22  3:39 ` Karthik Nayak [this message]
2015-08-22  3:39 ` [PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack Karthik Nayak
2015-08-24 21:56   ` Junio C Hamano
2015-08-25 10:26     ` Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 03/12] utf8: add function to align a string into given strbuf Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 04/12] ref-filter: implement an `align` atom Karthik Nayak
2015-08-24 22:13   ` Junio C Hamano
2015-08-24 22:15     ` Junio C Hamano
2015-08-25 13:28       ` Karthik Nayak
2015-08-25  6:47     ` Matthieu Moy
2015-08-25 13:30       ` Karthik Nayak
2015-08-25 17:56         ` Junio C Hamano
2015-08-26  6:41           ` Karthik Nayak
2015-08-25 17:52       ` Junio C Hamano
2015-08-25 13:28     ` Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 05/12] ref-filter: add option to filter out tags, branches and remotes Karthik Nayak
2015-08-24 22:24   ` Junio C Hamano
2015-08-25 13:07     ` Karthik Nayak
2015-08-26 16:10   ` Michael Haggerty
2015-08-27 12:42     ` Karthik Nayak
2015-08-27 15:24       ` Michael Haggerty
2015-08-27 15:35         ` Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 06/12] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 07/12] ref-filter: add support to sort by version Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 08/12] ref-filter: add option to match literal pattern Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 09/12] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 10/12] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 11/12] tag.c: implement '--format' option Karthik Nayak
2015-08-23 19:56   ` Matthieu Moy
2015-08-24 15:07     ` Karthik Nayak
2015-08-24 15:14       ` Matthieu Moy
2015-08-24 15:21         ` Karthik Nayak
2015-08-22  3:39 ` [PATCH v13 12/12] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-08-23 20:00 ` [PATCH v13 00/12] port tag.c to use ref-filter APIs Matthieu Moy
2015-08-24 15:09   ` Karthik Nayak
2015-08-24 15:16     ` Matthieu Moy
2015-08-24 15:22       ` Karthik Nayak
2015-08-24 22:34   ` Junio C Hamano
2015-08-24 22:58     ` Junio C Hamano
2015-08-25 13:26       ` Karthik Nayak
2015-08-25 19:16         ` Junio C Hamano
2015-08-25 19:43           ` Junio C Hamano
2015-08-26  5:56           ` Karthik Nayak
2015-08-26 14:37             ` Junio C Hamano
2015-08-26 19:14               ` Karthik Nayak
2015-08-26 20:19                 ` Junio C Hamano
2015-08-27 18:00                   ` Karthik Nayak
2015-08-25 13:23     ` Karthik Nayak
2015-08-24 17:27 ` Junio C Hamano
2015-08-24 18:09   ` Karthik Nayak
2015-08-24 18:53     ` Junio C Hamano
2015-08-24 22:35       ` Junio C Hamano
2015-08-26 10:07         ` Karthik Nayak
2015-08-26 11:54           ` Matthieu Moy
2015-08-26 15:44             ` Junio C Hamano
2015-08-26 15:46               ` Junio C Hamano
2015-08-26 15:48                 ` Matthieu Moy
2015-08-26 19:11                   ` Karthik Nayak
2015-08-25 13:25       ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440214788-1309-2-git-send-email-Karthik.188@gmail.com \
    --to=karthik.188@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).