From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com
Cc: hvoigt@hvoigt.net, git@vger.kernel.org, jens.lehmann@web.de,
jrnieder@gmail.com, peff@peff.net, wking@tremily.us,
sunshine@sunshineco.com, karsten.blees@gmail.com,
Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH v5 0/4] submodule config lookup API
Date: Wed, 12 Aug 2015 12:13:56 -0700 [thread overview]
Message-ID: <1439406838-6290-1-git-send-email-sbeller@google.com> (raw)
On Wed, Aug 12, 2015 at 10:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> On Mon, Jun 15, 2015 at 2:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Thanks. Will replace and wait for comments from others.
>>
>> I have reviewed the patches carefully and they look good to me.
>
> OK, I recall there were a few iterations with review comments before
> this round. Is it your impression that they have been addressed
> adequately?
I payed only little attention to the previous rounds and the review comments
thereof, because round 5 was up for quite a long time and nobody commented so far.
However just as I was convinced of my review and sent out the email, I started
working with it. And I found nits which I'd ask you to squash into the round or
put on top.
>
> Do you prefer it to be rebased to a more recent 'master' before you
> build your work on top of it (I think the topic currently builds on
> top of v2.5.0-rc0~56)?
Looking at the reviews for the "RFC parallel fetch for submodules"
I'd like to use `argv_array_pushv` which was introduced via
85b343245b (2015-06-14, argv-array: implement argv_array_pushv())
and is already in origin/next, but not origin/master.
But as I first work on the submodule--helper (both the small helper
functions as well as the whole "update" thereafter), I think this
dependency is not a pressing issue yet.
>
> Thanks.
Stefan Beller (2):
Fixup hv/documentation
cleanup submodule_config a bit.
Documentation/technical/api-submodule-config.txt | 3 +--
submodule-config.c | 12 +++++-------
2 files changed, 6 insertions(+), 9 deletions(-)
--
2.5.0.234.gefc8a62
next reply other threads:[~2015-08-12 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 19:13 Stefan Beller [this message]
2015-08-12 19:13 ` [PATCH 1/2] Fixup hv/documentation Stefan Beller
2015-08-12 19:13 ` [PATCH 2/2] cleanup submodule_config a bit Stefan Beller
2015-08-12 21:13 ` Eric Sunshine
2015-08-12 21:34 ` Stefan Beller
2015-08-12 22:01 ` Eric Sunshine
2015-08-12 19:27 ` [PATCH v5 0/4] submodule config lookup API Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2015-06-15 21:06 Heiko Voigt
2015-06-15 21:48 ` Junio C Hamano
2015-08-10 19:23 ` Stefan Beller
2015-08-12 17:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439406838-6290-1-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
--cc=jrnieder@gmail.com \
--cc=karsten.blees@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).