From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
Jens.Lehmann@web.de, hvoigt@hvoigt.net, gitster@pobox.com
Subject: [RFC/PATCH 2/2] Testing the new code
Date: Fri, 31 Jul 2015 16:09:07 -0700 [thread overview]
Message-ID: <1438384147-3275-3-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1438384147-3275-1-git-send-email-sbeller@google.com>
In-Reply-To: <1438301956-1658-1-git-send-email-sbeller@google.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
Notes:
The output of the differential testing is below,
which points out 2 bugs:
* resolving relative paths seems is broken, so we
would need to have the equivalent of
eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")"
(091a6eb0, 2013-06-16, submodule: drop the top-level requirement)
* The handling of funny characters is broken.
----------------------------------------------
../init
160000 9ab41d0d44279924747e3eafa6da77966579aa45 0 init
----
----
----
fatal: ../init: '../init' is outside repository
----------------------------------------------
../init
160000 37b832c3ae4dcc0830b173572ff59be6b089bdcd 0 init
----
----
----
fatal: ../init: '../init' is outside repository
----------------------------------------------
../init
160000 9ab41d0d44279924747e3eafa6da77966579aa45 0 init
----
----
----
fatal: ../init: '../init' is outside repository
----------------------------------------------
160000 37b832c3ae4dcc0830b173572ff59be6b089bdcd 0 example2
160000 9ab41d0d44279924747e3eafa6da77966579aa45 0 init
160000 01b25b1d44b1049978e053768790100df8b8d9d9 0 å äö
----
160000 37b832c3ae4dcc0830b173572ff59be6b089bdcd 0 example2
160000 9ab41d0d44279924747e3eafa6da77966579aa45 0 init
160000 01b25b1d44b1049978e053768790100df8b8d9d9 0 "\303\245 \303\244\303\266"
----
----
git-submodule.sh | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 36797c3..717b74d 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -149,7 +149,7 @@ relative_path ()
# Get submodule info for registered submodules
# $@ = path to limit submodule list
#
-module_list()
+module_list_shell()
{
eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")"
(
@@ -187,6 +187,29 @@ module_list()
'
}
+module_list()
+{
+ # call both the old and new code
+ module_list_shell $@ >/u/git_submodule_module_list_shell 2>/u/git_submodule_module_list_shell2
+ git submodule--helper --module_list $@ >/u/git_submodule_module_list 2>/u/git_submodule_module_list2
+ # if there is a diff record it
+ DIFF=$(diff /u/git_submodule_module_list_shell /u/git_submodule_module_list)
+ if [ "$DIFF" != "" ]
+ then
+ echo "----------------------------------------------">>/u/git_submodule_module_diffs
+ echo $@ >>/u/git_submodule_module_diffs
+ cat /u/git_submodule_module_list_shell >>/u/git_submodule_module_diffs
+ echo "----" >>/u/git_submodule_module_diffs
+ cat /u/git_submodule_module_list >>/u/git_submodule_module_diffs
+ echo "----" >>/u/git_submodule_module_diffs
+ cat /u/git_submodule_module_list_shell2 >>/u/git_submodule_module_diffs
+ echo "----" >>/u/git_submodule_module_diffs
+ cat /u/git_submodule_module_list2 >>/u/git_submodule_module_diffs
+ fi
+ # output to the caller
+ cat /u/git_submodule_module_list
+}
+
die_if_unmatched ()
{
if test "$1" = "#unmatched"
--
2.5.0.5.gf4cd9ae.dirty
next prev parent reply other threads:[~2015-07-31 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 0:19 [PATCH] add: remove dead code Stefan Beller
2015-07-31 16:41 ` Junio C Hamano
2015-07-31 23:09 ` [RFC/PATCH 0/2] Submodules: refactoring the `module_list` function Stefan Beller
2015-07-31 23:09 ` [RFC/PATCH 1/2] submodule: implement `module_list` as a builtin helper Stefan Beller
2015-08-01 1:01 ` Junio C Hamano
2015-08-03 21:30 ` Stefan Beller
2015-08-03 21:38 ` Junio C Hamano
2015-08-03 21:58 ` [PATCH] " Stefan Beller
2015-08-03 22:04 ` [RFC/PATCH 1/2] " Junio C Hamano
2015-08-03 22:13 ` Stefan Beller
2015-08-03 22:58 ` [PATCH] " Stefan Beller
2015-07-31 23:09 ` Stefan Beller [this message]
2015-08-01 1:02 ` [RFC/PATCH 2/2] Testing the new code Junio C Hamano
2015-08-03 16:23 ` Stefan Beller
2015-08-03 19:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438384147-3275-3-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).