From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "sbeller@google.com" <sbeller@google.com>,
"dev+git@drbeat.li" <dev+git@drbeat.li>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH] gitk: Add a "Copy commit summary" command
Date: Wed, 15 Jul 2015 22:24:57 +0000 [thread overview]
Message-ID: <1436999097.12921.2.camel@intel.com> (raw)
In-Reply-To: <CAGZ79kaB-vrarcCztD_7x5M1_dHWwMy=6vQ5EHHsWTJTWEyhOA@mail.gmail.com>
On Tue, 2015-07-14 at 13:34 -0700, Stefan Beller wrote:
> On Tue, Jul 14, 2015 at 9:42 AM, <dev+git@drbeat.li> wrote:
> > From: Beat Bolli <dev+git@drbeat.li>
> >
> > When referencing earlier commits in new commit messages or other
> > text,
> > one of the established formats is
> >
> > commit <abbrev-sha> ("<summary>", <author-date>)
>
> That sounds like I would use it a lot! Thanks :)
>
Yep, quite useful. Also, the kernel suggests using it as a tag like so
Fixes: <abbrev-sha> ("summary")
I really like this :)
Regards,
Jake
> >
> > Add a "Copy commit summary" command to the context menu that puts
> > this
> > text for the currently selected commit on the clipboard. This makes
> > it
> > easy for our users to create well-formatted commit references.
> >
> > Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> > Cc: Paul Mackerras <paulus@samba.org>
> > ---
> > gitk-git/gitk | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/gitk-git/gitk b/gitk-git/gitk
> > index 9a2daf3..0612331 100755
> > --- a/gitk-git/gitk
> > +++ b/gitk-git/gitk
> > @@ -2617,6 +2617,7 @@ proc makewindow {} {
> > {mc "Diff selected -> this" command {diffvssel 1}}
> > {mc "Make patch" command mkpatch}
> > {mc "Create tag" command mktag}
> > + {mc "Copy commit summary" command copysummary}
> > {mc "Write commit to file" command writecommit}
> > {mc "Create new branch" command mkbranch}
> > {mc "Cherry-pick this commit" command cherrypick}
> > @@ -9341,6 +9342,19 @@ proc mktaggo {} {
> > mktagcan
> > }
> >
> > +proc copysummary {} {
> > + global rowmenuid commitinfo
> > +
> > + set id [string range $rowmenuid 0 7]
> > + set info $commitinfo($rowmenuid)
> > + set commit [lindex $info 0]
> > + set date [formatdate [lindex $info 2]]
> > + set summary "[mc "commit"] $id (\"$commit\", $date)"
> > +
> > + clipboard clear
> > + clipboard append $summary
> > +}
> > +
> > proc writecommit {} {
> > global rowmenuid wrcomtop commitinfo wrcomcmd NS
> >
> > --
> > 2.1.4
> > --
> > To unsubscribe from this list: send the line "unsubscribe git" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-15 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 16:42 [PATCH] gitk: Add a "Copy commit summary" command dev+git
2015-07-14 20:34 ` Stefan Beller
2015-07-15 22:24 ` Keller, Jacob E [this message]
2015-07-15 23:58 ` Eric Sunshine
2015-07-16 0:59 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436999097.12921.2.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).