git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org, gitster@pobox.com, Shawn Pearce <sop@google.com>
Subject: Re: [PATCH] Documentation: finding $(prefix)/etc/gitconfig when prefix = /usr
Date: Mon, 8 Jul 2013 00:32:06 +0200 (CEST)	[thread overview]
Message-ID: <1436467098.1055670.1373236326672.JavaMail.root@dewire.com> (raw)
In-Reply-To: <20130707222152.GV9161@serenity.lan>



----- Ursprungligt meddelande -----
> On Mon, Jul 08, 2013 at 12:00:02AM +0200, Robin Rosenberg wrote:
> > Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> > ---
> >  Documentation/git-config.txt | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/git-config.txt
> > b/Documentation/git-config.txt
> > index 9ae2508..3198d52 100644
> > --- a/Documentation/git-config.txt
> > +++ b/Documentation/git-config.txt
> > @@ -107,7 +107,8 @@ See also <<FILES>>.
> >  
> >  --system::
> >  	For writing options: write to system-wide $(prefix)/etc/gitconfig
> > -	rather than the repository .git/config.
> > +	rather than the repository .git/config. However, $(prefix) is
> > /usr
> > +	then /etc/gitconfig is used.
> 
> That's a build time condition, not something that's decided at
> runtime
> so I'm not sure that this logic belongs in the user facing
> documentation.  The technically correct change would be to use
> "$(sysconfdir)/gitconfig" but I think that will just confuse users
> more.
> 
> Since we have a build step for the documentation, I wonder if it's
> possible to replace these with the correct directory at build time.

Might work for documentation. I'd like a run-time variant for my
particular problem, but the one I found now, e.g. git rev-parse --show-prefix"
does not work in the general case. I want to tell JGit where the system
wide configuration file is, even before we have a git repository.

-- robin

  reply	other threads:[~2013-07-07 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 22:00 [PATCH] Documentation: finding $(prefix)/etc/gitconfig when prefix = /usr Robin Rosenberg
2013-07-07 22:21 ` John Keeping
2013-07-07 22:32   ` Robin Rosenberg [this message]
2013-07-07 22:23 ` Robin Rosenberg
2013-07-07 22:47   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436467098.1055670.1373236326672.JavaMail.root@dewire.com \
    --to=robin.rosenberg@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@keeping.me.uk \
    --cc=sop@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).