From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Luke Diamand <luke@diamand.org>
Subject: [PATCHv3 0/3] git-p4: fix handling of multi-word P4EDITOR
Date: Tue, 19 May 2015 23:23:15 +0100 [thread overview]
Message-ID: <1432074198-13806-1-git-send-email-luke@diamand.org> (raw)
In-Reply-To: <xmqqa8x0a7wq.fsf@gitster.dls.corp.google.com>
Junio noticed that my new test was using touch, which is a bit
racetastic because git-p4 wants P4EDITOR to spend at least one
second editing the submit template or it will fail.
This updates the test to use test-chmtime, and also fixes the
other git-p4 tests in the same way.
Luke Diamand (3):
git-p4: add failing test for P4EDITOR handling
git-p4: fix handling of multi-word P4EDITOR
git-p4: tests: use test-chmtime in place of touch
git-p4.py | 2 +-
t/t9803-git-p4-shell-metachars.sh | 4 ++--
t/t9805-git-p4-skip-submit-edit.sh | 4 ++--
t/t9813-git-p4-preserve-users.sh | 7 ++++---
t/t9820-git-p4-editor-handling.sh | 38 ++++++++++++++++++++++++++++++++++++++
5 files changed, 47 insertions(+), 8 deletions(-)
create mode 100755 t/t9820-git-p4-editor-handling.sh
--
2.4.1.502.gb11c5ab
next prev parent reply other threads:[~2015-05-19 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 6:40 git-p4: test t9820-git-p4-editor-handling.sh failing Luke Diamand
2015-05-19 15:44 ` Junio C Hamano
2015-05-19 22:23 ` Luke Diamand [this message]
2015-05-19 22:23 ` [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling Luke Diamand
2015-05-20 19:54 ` Junio C Hamano
2015-05-20 20:56 ` Junio C Hamano
2015-05-20 21:43 ` Luke Diamand
2015-05-19 22:23 ` [PATCHv3 2/3] git-p4: fix handling of multi-word P4EDITOR Luke Diamand
2015-05-19 22:23 ` [PATCHv3 3/3] git-p4: tests: use test-chmtime in place of touch Luke Diamand
2015-05-19 22:36 ` Luke Diamand
2015-05-24 18:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432074198-13806-1-git-send-email-luke@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).