From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Stefan Beller" <sbeller@google.com>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v2 00/12] Allow reference values to be checked in a transaction
Date: Thu, 12 Feb 2015 12:12:11 +0100 [thread overview]
Message-ID: <1423739543-1025-1-git-send-email-mhagger@alum.mit.edu> (raw)
This is v2 of the patch series, with only minor changes from v1 [1].
Thanks to Stefan Beller and Junio for their feedback about v1. I think
I have addressed all of the points that were raised.
Changes since v1:
* Rebased onto new upstream master (because it now includes the
dependencies, mh/reflog-expire and sb/atomic-push). The rebase was
conflict-free.
* Tweaked some commit messages and added some Reviewed-by lines.
* Patch 06/11: Remove copyright line from t7516. Use write_script
function to write the fake editor.
* Patch 12/11: New commit: consolidate comments for the four reference
transaction update functions.
This branch is also available in my GitHub account [2] as branch
"refs-have-new".
Michael
[1] http://thread.gmane.org/gmane.comp.version-control.git/263522
[2] https://github.com/mhagger/git
Michael Haggerty (12):
refs: move REF_DELETING to refs.c
refs: remove the gap in the REF_* constant values
struct ref_update: move "have_old" into "flags"
ref_transaction_update(): remove "have_old" parameter
ref_transaction_delete(): remove "have_old" parameter
commit: add tests of commit races
commit: avoid race when creating orphan commits
ref_transaction_create(): check that new_sha1 is valid
ref_transaction_delete(): check that old_sha1 is not null_sha1
ref_transaction_verify(): new function to check a reference's value
update_ref(): improve documentation
refs.h: Remove duplication in function docstrings
branch.c | 5 +-
builtin/commit.c | 4 +-
builtin/fetch.c | 6 ++-
builtin/receive-pack.c | 5 +-
builtin/replace.c | 2 +-
builtin/tag.c | 2 +-
builtin/update-ref.c | 17 +++----
fast-import.c | 6 +--
refs.c | 130 +++++++++++++++++++++++++++++++++---------------
refs.h | 111 ++++++++++++++++++++++++++++-------------
sequencer.c | 2 +-
t/t7516-commit-races.sh | 33 ++++++++++++
walker.c | 2 +-
13 files changed, 227 insertions(+), 98 deletions(-)
create mode 100755 t/t7516-commit-races.sh
--
2.1.4
next reply other threads:[~2015-02-12 11:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:12 Michael Haggerty [this message]
2015-02-12 11:12 ` [PATCH v2 01/12] refs: move REF_DELETING to refs.c Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 02/12] refs: remove the gap in the REF_* constant values Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 03/12] struct ref_update: move "have_old" into "flags" Michael Haggerty
2015-02-12 18:08 ` Stefan Beller
2015-02-12 19:15 ` Junio C Hamano
2015-02-17 14:37 ` Michael Haggerty
2015-02-17 15:52 ` Junio C Hamano
2015-02-12 11:12 ` [PATCH v2 04/12] ref_transaction_update(): remove "have_old" parameter Michael Haggerty
2015-02-12 17:32 ` Junio C Hamano
2015-02-13 17:15 ` Michael Haggerty
2015-02-13 18:27 ` Junio C Hamano
2015-02-12 11:12 ` [PATCH v2 05/12] ref_transaction_delete(): " Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 06/12] commit: add tests of commit races Michael Haggerty
2015-02-12 18:13 ` Stefan Beller
2015-02-17 14:44 ` Michael Haggerty
2015-02-12 19:36 ` Junio C Hamano
2015-02-17 15:06 ` Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 07/12] commit: avoid race when creating orphan commits Michael Haggerty
2015-02-12 19:36 ` Junio C Hamano
2015-02-12 11:12 ` [PATCH v2 08/12] ref_transaction_create(): check that new_sha1 is valid Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 09/12] ref_transaction_delete(): check that old_sha1 is not null_sha1 Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 10/12] ref_transaction_verify(): new function to check a reference's value Michael Haggerty
2015-02-12 18:21 ` Stefan Beller
2015-02-12 11:12 ` [PATCH v2 11/12] update_ref(): improve documentation Michael Haggerty
2015-02-12 11:12 ` [PATCH v2 12/12] refs.h: Remove duplication in function docstrings Michael Haggerty
2015-02-12 19:44 ` [PATCH v2 00/12] Allow reference values to be checked in a transaction Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423739543-1025-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).