From: Max Kirillov <max@max630.net>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org, Max Kirillov <max@max630.net>
Subject: [PATCH 3/3] gitk: merge views with existing ones
Date: Thu, 11 Sep 2014 08:21:28 +0300 [thread overview]
Message-ID: <1410412888-10187-4-git-send-email-max@max630.net> (raw)
In-Reply-To: <1410412888-10187-1-git-send-email-max@max630.net>
Only new and modified views are saved; old ones are saved also
if there are no new, modified or deleted view with same name.
This allows editing view list in concurrent gitk sessions without
losing the changes.
Signed-off-by: Max Kirillov <max@max630.net>
---
gitk | 42 +++++++++++++++++++++++++++++++++++++++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/gitk b/gitk
index 6e22024..3394415 100755
--- a/gitk
+++ b/gitk
@@ -2807,7 +2807,11 @@ proc doprogupdate {} {
proc config_variable_change_cb {name name2 op} {
global config_variable_changed
if {$op eq "write"} {
- set config_variable_changed($name) 1
+ if {$name2 eq ""} {
+ set config_variable_changed($name) 1
+ } else {
+ set config_variable_changed($name,$name2) 1
+ }
}
}
@@ -2861,12 +2865,38 @@ proc savestuff {w} {
puts $f "set geometry(botwidth) [winfo width .bleft]"
puts $f "set geometry(botheight) [winfo height .bleft]"
+ array set view_save {}
+ array set views {}
+ foreach view $permviews {
+ set view_save([lindex $view 0]) 1
+ set views([lindex $view 0]) $view
+ }
puts -nonewline $f "set permviews {"
for {set v 0} {$v < $current_nextviewnum} {incr v} {
- if {$current_viewperm($v)} {
- puts $f "{[list $current_viewname($v) $current_viewfiles($v) $current_viewargs($v) $current_viewargscmd($v)]}"
+ if {$config_variable_changed(viewname,$v) ||
+ $config_variable_changed(viewfiles,$v) ||
+ $config_variable_changed(viewargs,$v) ||
+ $config_variable_changed(viewargscmd,$v) ||
+ $config_variable_changed(viewperm,$v)} {
+ if {$current_viewperm($v)} {
+ set views($current_viewname($v)) [list $current_viewname($v) $current_viewfiles($v) $current_viewargs($v) $current_viewargscmd($v)]
+ } else {
+ set view_save($current_viewname($v)) 0
+ }
+ lappend views_modified_names $current_viewname($v)
}
}
+ # write old and updated view to their places and append remaining to the end
+ foreach view $permviews {
+ set view_name [lindex $view 0]
+ if {$view_save($view_name)} {
+ puts $f "{$views($view_name)}"
+ }
+ unset views($view_name)
+ }
+ foreach view_name [array names views] {
+ puts $f "{$views($view_name)}"
+ }
puts $f "}"
close $f
file rename -force $config_file_tmp $config_file
@@ -12828,6 +12858,12 @@ if {[info exists permviews]} {
addviewmenu $n
}
}
+foreach var {viewname viewfiles viewargs viewargscmd viewperm} {
+ for {set v 0} {$v < $nextviewnum} {incr v} {
+ set config_variable_changed($var,$v) 0
+ }
+ trace add variable $var write config_variable_change_cb
+}
if {[tk windowingsystem] eq "win32"} {
focus -force .
--
2.0.1.1697.g73c6810
prev parent reply other threads:[~2014-09-11 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 5:21 [PATCH 0/3] gitk: save only changed configuration on exit Max Kirillov
2014-09-11 5:21 ` [PATCH 1/3] gitk refactor: remove boilerplate for configuration variables Max Kirillov
2014-09-11 5:21 ` [PATCH 2/3] gitk: write only changed " Max Kirillov
2014-09-11 17:19 ` Junio C Hamano
2014-09-11 19:17 ` Max Kirillov
2014-09-11 20:26 ` Junio C Hamano
2014-09-11 5:21 ` Max Kirillov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410412888-10187-4-git-send-email-max@max630.net \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).