From: Ronnie Sahlberg <sahlberg@google.com>
To: git@vger.kernel.org
Cc: Ronnie Sahlberg <sahlberg@google.com>
Subject: [PATCH v2 13/14] refs.c: make unlock_ref/close_ref/commit_ref static
Date: Mon, 16 Jun 2014 09:51:44 -0700 [thread overview]
Message-ID: <1402937505-6091-14-git-send-email-sahlberg@google.com> (raw)
In-Reply-To: <1402937505-6091-1-git-send-email-sahlberg@google.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
refs.c | 24 ++++++++++++------------
refs.h | 9 ---------
2 files changed, 12 insertions(+), 21 deletions(-)
diff --git a/refs.c b/refs.c
index f579d63..3f16445 100644
--- a/refs.c
+++ b/refs.c
@@ -1962,6 +1962,16 @@ int refname_match(const char *abbrev_name, const char *full_name)
return 0;
}
+static void unlock_ref(struct ref_lock *lock)
+{
+ /* Do not free lock->lk -- atexit() still looks at them */
+ if (lock->lk)
+ rollback_lock_file(lock->lk);
+ free(lock->ref_name);
+ free(lock->orig_ref_name);
+ free(lock);
+}
+
/* This function should make sure errno is meaningful on error */
static struct ref_lock *verify_lock(struct ref_lock *lock,
const unsigned char *old_sha1, int mustexist)
@@ -2786,7 +2796,7 @@ int rename_ref(const char *oldrefname, const char *newrefname, const char *logms
return 1;
}
-int close_ref(struct ref_lock *lock)
+static int close_ref(struct ref_lock *lock)
{
if (close_lock_file(lock->lk))
return -1;
@@ -2794,7 +2804,7 @@ int close_ref(struct ref_lock *lock)
return 0;
}
-int commit_ref(struct ref_lock *lock)
+static int commit_ref(struct ref_lock *lock)
{
if (commit_lock_file(lock->lk))
return -1;
@@ -2802,16 +2812,6 @@ int commit_ref(struct ref_lock *lock)
return 0;
}
-void unlock_ref(struct ref_lock *lock)
-{
- /* Do not free lock->lk -- atexit() still looks at them */
- if (lock->lk)
- rollback_lock_file(lock->lk);
- free(lock->ref_name);
- free(lock->orig_ref_name);
- free(lock);
-}
-
/*
* copy the reflog message msg to buf, which has been allocated sufficiently
* large, while cleaning up the whitespaces. Especially, convert LF to space,
diff --git a/refs.h b/refs.h
index c19ca82..2025b96 100644
--- a/refs.h
+++ b/refs.h
@@ -193,15 +193,6 @@ extern struct ref_lock *lock_any_ref_for_update(const char *refname,
const unsigned char *old_sha1,
int flags, int *type_p);
-/** Close the file descriptor owned by a lock and return the status */
-extern int close_ref(struct ref_lock *lock);
-
-/** Close and commit the ref locked by the lock */
-extern int commit_ref(struct ref_lock *lock);
-
-/** Release any lock taken but not written. **/
-extern void unlock_ref(struct ref_lock *lock);
-
/** Reads log for the value of ref during at_time. **/
extern int read_ref_at(const char *refname, unsigned long at_time, int cnt,
unsigned char *sha1, char **msg,
--
2.0.0.770.gd892650.dirty
next prev parent reply other threads:[~2014-06-16 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 16:51 [PATCH v2 00/14] ref-transactions-reflog Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 01/14] refs.c make ref_transaction_create a wrapper to ref_transaction_update Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 02/14] refs.c: make ref_transaction_delete a wrapper for ref_transaction_update Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 03/14] refs.c: rename the transaction functions Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 04/14] refs.c: add a new update_type field to ref_update Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 05/14] refs.c: add a function to append a reflog entry to a fd Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 06/14] lockfile.c: make hold_lock_file_for_append preserve meaningful errno Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 07/14] refs.c: add a transaction function to append a reflog entry Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 08/14] refs.c: add a flag to allow reflog updates to truncate the log Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 09/14] refs.c: only write reflog update if msg is non-NULL Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 10/14] refs.c: allow multiple reflog updates during a single transaction Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 11/14] reflog.c: use a reflog transaction when writing during expire Ronnie Sahlberg
2014-06-16 16:51 ` [PATCH v2 12/14] refs.c: rename log_ref_setup to create_reflog Ronnie Sahlberg
2014-06-16 16:51 ` Ronnie Sahlberg [this message]
2014-06-16 16:51 ` [PATCH v2 14/14] refs.c: remove lock_any_ref_for_update Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402937505-6091-14-git-send-email-sahlberg@google.com \
--to=sahlberg@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).