From: "Michael Rappazzo via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Michael Rappazzo <rappazzo@gmail.com>
Subject: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'
Date: Thu, 13 Dec 2018 11:54:11 -0800 (PST) [thread overview]
Message-ID: <13ee60e44f91ca06d182ff50fa4c69e137650fd2.1544730848.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.100.git.gitgitgadget@gmail.com>
From: Michael Rappazzo <rappazzo@gmail.com>
On a worktree which is not the primary, using the symbolic-ref 'head' was
incorrectly pointing to the main worktree's HEAD. The same was true for
any other case of the word 'Head'.
Signed-off-by: Michael Rappazzo <rappazzo@gmail.com>
---
refs.c | 8 ++++----
t/t1415-worktree-refs.sh | 9 +++++++++
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index f9936355cd..963e786458 100644
--- a/refs.c
+++ b/refs.c
@@ -579,7 +579,7 @@ int expand_ref(const char *str, int len, struct object_id *oid, char **ref)
*ref = xstrdup(r);
if (!warn_ambiguous_refs)
break;
- } else if ((flag & REF_ISSYMREF) && strcmp(fullref.buf, "HEAD")) {
+ } else if ((flag & REF_ISSYMREF) && strcasecmp(fullref.buf, "HEAD")) {
warning(_("ignoring dangling symref %s"), fullref.buf);
} else if ((flag & REF_ISBROKEN) && strchr(fullref.buf, '/')) {
warning(_("ignoring broken ref %s"), fullref.buf);
@@ -627,7 +627,7 @@ int dwim_log(const char *str, int len, struct object_id *oid, char **log)
static int is_per_worktree_ref(const char *refname)
{
- return !strcmp(refname, "HEAD") ||
+ return !strcasecmp(refname, "HEAD") ||
starts_with(refname, "refs/worktree/") ||
starts_with(refname, "refs/bisect/") ||
starts_with(refname, "refs/rewritten/");
@@ -847,7 +847,7 @@ int should_autocreate_reflog(const char *refname)
return starts_with(refname, "refs/heads/") ||
starts_with(refname, "refs/remotes/") ||
starts_with(refname, "refs/notes/") ||
- !strcmp(refname, "HEAD");
+ !strcasecmp(refname, "HEAD");
default:
return 0;
}
@@ -855,7 +855,7 @@ int should_autocreate_reflog(const char *refname)
int is_branch(const char *refname)
{
- return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
+ return !strcasecmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
}
struct read_ref_at_cb {
diff --git a/t/t1415-worktree-refs.sh b/t/t1415-worktree-refs.sh
index b664e51250..e7f8a129fd 100755
--- a/t/t1415-worktree-refs.sh
+++ b/t/t1415-worktree-refs.sh
@@ -76,4 +76,13 @@ test_expect_success 'reflog of worktrees/xx/HEAD' '
test_cmp expected actual.wt2
'
+test_expect_success 'head, Head, and HEAD are the same in worktree' '
+ test_cmp_rev worktree/foo initial &&
+ git -C wt1 rev-parse HEAD >uc_ref.wt1 &&
+ git -C wt1 rev-parse Head >mc_ref.wt1 &&
+ git -C wt1 rev-parse head >lc_ref.wt1 &&
+ test_cmp uc_ref.wt1 lc_ref.wt1 &&
+ test_cmp uc_ref.wt1 mc_ref.wt1
+'
+
test_done
--
gitgitgadget
next prev parent reply other threads:[~2018-12-13 19:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 19:54 [PATCH 0/1] worktree refs: fix case sensitivity for 'head' Michael Rappazzo via GitGitGadget
2018-12-13 19:54 ` Michael Rappazzo via GitGitGadget [this message]
2018-12-13 20:23 ` [PATCH 1/1] " Duy Nguyen
2018-12-13 20:34 ` Mike Rappazzo
2018-12-13 20:43 ` Duy Nguyen
2018-12-13 20:47 ` Stefan Beller
2018-12-13 21:14 ` Mike Rappazzo
2018-12-14 0:33 ` brian m. carlson
2018-12-14 6:49 ` Jacob Keller
2018-12-14 7:37 ` Duy Nguyen
2018-12-14 17:22 ` Jacob Keller
2018-12-14 17:38 ` Duy Nguyen
2018-12-14 17:46 ` Duy Nguyen
2018-12-14 18:48 ` Jacob Keller
2018-12-14 18:47 ` Jacob Keller
2018-12-13 21:07 ` Mike Rappazzo
2018-12-14 3:31 ` Junio C Hamano
2018-12-14 10:36 ` [PATCH 0/1] " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13ee60e44f91ca06d182ff50fa4c69e137650fd2.1544730848.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rappazzo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).