From: Philip Oakley <philipoakley@iee.email>
To: Jeff King <peff@peff.net>, Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] fetch: support hideRefs to speed up connectivity checks
Date: Mon, 13 Feb 2023 23:30:35 +0000 [thread overview]
Message-ID: <13cef8e7-71af-27a5-77a3-a08f75720d1a@iee.email> (raw)
In-Reply-To: <Y+qjRZTn7DNib1uB@coredump.intra.peff.net>
On 13/02/2023 20:53, Jeff King wrote:
> On Sun, Feb 12, 2023 at 09:04:26AM +0000, Eric Wong wrote:
>
>> Sidenote: I'm curious about the reason $(pwd) is used in some
>> places while $PWD seems fine in others, so it doesn't seem to be
>> a portability problem. I chose $PWD since it's faster.
> It sometimes matters; one is a Windows path (with "C:\", etc) and one is
> a Unix-style path. Many spots are happy with either type, but it
> sometimes bites us when doing string comparisons, or in a few specific
> cases. See
>
> https://lore.kernel.org/git/d36d8b51-f2d7-a2f5-89ea-369f49556e10@kdbg.org/
>
> for an example.
>
There is guidance in t/README L680-684 though it maybe not that easy to
spot.
A more recent patch was
https://lore.kernel.org/git/4f5c5633-f5a2-3c99-329e-3057b8d447d2@kdbg.org/
with slightly more details.
Philip
next prev parent reply other threads:[~2023-02-13 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 12:28 [RFC] fetch: support hideRefs to speed up connectivity checks Eric Wong
2023-02-10 21:49 ` Jonathan Tan
2023-02-10 21:59 ` Eric Wong
2023-02-10 22:56 ` Junio C Hamano
2023-02-11 7:53 ` Eric Wong
2023-02-11 19:24 ` Junio C Hamano
2023-02-12 9:04 ` [PATCH v2] " Eric Wong
2023-02-13 20:53 ` Jeff King
2023-02-13 23:30 ` Philip Oakley [this message]
2023-02-14 1:40 ` Jeff King
2023-02-16 1:32 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13cef8e7-71af-27a5-77a3-a08f75720d1a@iee.email \
--to=philipoakley@iee.email \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).