Re: [PATCH v2 1/2] add-patch: introduce 'p' in interactive-patch

[Phillip Wood <phillip.wood123@gmail.com>]

Hi Rubén

On 26/03/2024 00:17, Rubén Justo wrote:
> Shortly we're going make interactive-patch stop printing automatically
> the hunk under certain circumstances.
> 
> Let's introduce a new option to allow the user to explicitly request
> the printing.

I wonder if we want to hide this option unless we've skipped rendering 
the hunk in the same way that we hide other options that are not 
relevant to the hunk being displayed. I also wonder if 'r' for 
"re-display" would better convey the intent of this keybinding.

> diff --git a/add-patch.c b/add-patch.c
> index 68f525b35c..444fd75b2a 100644
> --- a/add-patch.c
> +++ b/add-patch.c
> @@ -1388,6 +1388,7 @@ N_("j - leave this hunk undecided, see next undecided hunk\n"
>      "/ - search for a hunk matching the given regex\n"
>      "s - split the current hunk into smaller hunks\n"
>      "e - manually edit the current hunk\n"
> +   "p - print again the current hunk\n"

I think "print the hunk again" is clearer (or "re-display the hunk" if 
we go for 'r')

Best Wishes

Phillip