From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 084/142] t7001-mv.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:45 -0700 Message-ID: <1395768283-31135-85-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:23 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDp-0004n1-9U for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:09 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754971AbaCYR2n convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:28:43 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:56178 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755432AbaCYR0Y (ORCPT ); Tue, 25 Mar 2014 13:26:24 -0400 Received: by mail-pb0-f45.google.com with SMTP id uo5so750502pbc.4 for ; Tue, 25 Mar 2014 10:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=R6xQIpRAwzVoTLlkcnFFlLR2alpIg9lWC8Xjm3OGR+Q=; b=UVdNnoC/61rHXEfDuRsr9/ouLd6vPBdbcD42X0djNjOmgS5EorHOkoUHYDmZ1OapNJ oUkk4tdPDor0A6shhzOV1NE5Jd0CSSrbRsslPaYlZK9QcLUZQDXNSSbZ6ola1OafE0KL K9+Xf0OPoRAbk1NsU78TJ8dInb66qGB7WNM6lRRQIXwIg+9Z6SObL69b1PqIcPxy/5Ia UQC4AxOhvFeprf8H9Bx3Rlppv6gN8K5cInUZFrq+qMlIKU7ivGOxFeLfCN1NdsZETQCF ESjsS624xE9ostSQ7qkX7RhAuXhkU3JRlug23ryjWXQgNuj12IgqciyfSrOTcITNO2mP wemA== X-Received: by 10.68.110.165 with SMTP id ib5mr80191103pbb.61.1395768384024; Tue, 25 Mar 2014 10:26:24 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.23 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:23 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t7001-mv.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh index e3c8c2c..23564bf 100755 --- a/t/t7001-mv.sh +++ b/t/t7001-mv.sh @@ -156,11 +156,11 @@ test_expect_success "Michael Cassar's test case" = ' echo b > partA/outline.txt && echo c > papers/unsorted/_another && git add papers partA && - T1=3D`git write-tree` && + T1=3D$(git write-tree) && =20 git mv papers/unsorted/Thesis.pdf papers/all-papers/moo-blah.pdf && =20 - T=3D`git write-tree` && + T=3D$(git write-tree) && git ls-tree -r $T | grep partA/outline.txt || { git ls-tree -r $T (exit 1) --=20 1.7.10.4